Skip to content

Remove 5.10 WASM support #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,9 @@ jobs:
strategy:
fail-fast: false
matrix:
swift_version: ["5.10.0-RELEASE", "6.0-SNAPSHOT-2024-09-18-a"]
swift_version: ["6.0.2-RELEASE"]
os: [ubuntu-22.04]
extra_params: [""]
include:
- swift_version: "6.0-SNAPSHOT-2024-09-18-a"
continue-on-error: true
- swift_version: "5.10.0-RELEASE"
continue-on-error: false
runs-on: ${{ matrix.os }}
env:
OPENSWIFTUI_WERROR: 1
Expand All @@ -35,8 +30,7 @@ jobs:
- name: build
run: |
swift build --triple wasm32-unknown-wasi ${{ matrix.extra_params }}
continue-on-error: ${{ matrix.continue-on-error }}
# Blocked by upstream support for WASM. See https://github.com/apple/swift-testing/issues/228
continue-on-error: true # See https://github.com/swiftwasm/swift/issues/5592
# - name: test
# run: |
# swift test --triple wasm32-unknown-wasi ${{ matrix.extra_params }}
304 changes: 0 additions & 304 deletions [email protected]

This file was deleted.

18 changes: 0 additions & 18 deletions Sources/OpenSwiftUICore/Data/Protobuf/ProtobufEncoder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,6 @@ extension ProtobufEncoder {
encodeVarintZZ(Int(value))
}

#if compiler(>=6.0)
/// Encodes a bitwise copyable value.
///
/// - Parameters:
Expand All @@ -757,23 +756,6 @@ extension ProtobufEncoder {
buffer.advanced(by: oldSize).storeBytes(of: value, as: T.self)
}
}
#else // FIXME: Remove this after we drop WASI 5.10 support
/// Encodes a bitwise copyable value.
///
/// - Parameters:
/// - value: The value to encode.
@inline(__always)
private mutating func encodeBitwiseCopyable<T>(_ value: T) {
let oldSize = size
let newSize = oldSize + MemoryLayout<T>.size
if capacity < newSize {
growBufferSlow(to: newSize).storeBytes(of: value, as: T.self)
} else {
size = newSize
buffer.advanced(by: oldSize).storeBytes(of: value, as: T.self)
}
}
#endif

/// Encodes a boolean value.
///
Expand Down
18 changes: 0 additions & 18 deletions Tests/OpenSwiftUICompatibilityTests/Scaffolding.swift

This file was deleted.

Loading
Loading