Skip to content

Remove deprecated parts of OMCPath #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c12c277
[OMCPath] add class
syntron Jun 28, 2025
908a239
[OMCPath] add implementation using OMC via sendExpression()
syntron Jun 27, 2025
00d016f
[OMCPath] add pytest (only docker at the moment)
syntron Jun 28, 2025
a449445
[OMCPath] TODO items
syntron Jun 28, 2025
17c9ee8
[test_OMCPath] mypy fix
syntron Jul 2, 2025
942635e
[test_OMCPath] fix end of file
syntron Jul 2, 2025
11b2524
[test_OMCPath] define test using OMCSessionZMQ() locally
syntron Jul 3, 2025
05b3c4d
add TODO - need to check Python versions
syntron Jul 6, 2025
79e118a
[test_OMCPath] activate docker based on test_docker
syntron Jul 6, 2025
e0cb453
[OMCPath] add more functionality and docstrings
syntron Jul 11, 2025
2b86442
[OMCPath] remove TODO entries
syntron Jul 11, 2025
a9fb9f9
[OMCPath] define limited compatibility for Python < 3.12
syntron Jul 11, 2025
fcb8571
[OMCSEssionZMQ] use OMCpath
syntron Jul 11, 2025
51b9160
[OMCSessionZMQ] create a tempdir using omcpath_tempdir()
syntron Jul 11, 2025
dd9afed
[OMCPath] fix mypy
syntron Jul 11, 2025
dc0393e
[OMCPath] add warning message for Python < 3.12
syntron Jul 11, 2025
6ff54d3
[OMCPath] try to make mypy happy ...
syntron Jul 11, 2025
c4323b3
[test_OMCPath] only for Python >= 3.12
syntron Jul 11, 2025
ec552dd
[test_OMCPath] update test
syntron Jul 11, 2025
3b99f2f
[OMCPath._omc_resolve] use sendExpression() with parsed=False
syntron Jul 12, 2025
a54b796
[test_OMCPath] cleanup; use the same code for local OMC and docker ba…
syntron Jul 12, 2025
02c40bc
[test_OMCPath] define test for WSL
syntron Jul 12, 2025
4feccf2
[test_OMCPath] use omcpath_tempdir() instead of hard-coded tempdir de…
syntron Jul 12, 2025
3625807
[OMCPath] spelling fix
syntron Jul 15, 2025
930cff1
[OMCPath] implementation version 3
syntron Jul 16, 2025
1de0e3b
[OMCSession*] fix flake8 (PyCharm likes the empty lines)
syntron Jul 16, 2025
8f38def
[OMCSessionZMQ] more generic definiton for omcpath_tempdir()
syntron Jul 16, 2025
9dc161b
[OMCPathCompatibility] mypy on github ...
syntron Jul 16, 2025
fd906cc
[OMCPathCompatibility] improve log messages
syntron Jul 16, 2025
90f8c98
[test_OMCPath] update
syntron Jul 16, 2025
b2a9190
[OMCPathReal] align exists() to the definition used in pathlib
syntron Jul 24, 2025
b11bfa9
[test_OMCPath] fix error
syntron Jul 26, 2025
f1e63bd
[OMCPath] remove compatibility code for Python < 3.12
syntron Jul 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/Test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
python-version: ['3.10', '3.12']
python-version: ['3.12', '3.13']
os: ['ubuntu-latest', 'windows-latest']
omc-version: ['stable']

Expand Down
178 changes: 178 additions & 0 deletions OMPython/OMCSession.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,151 @@ def getClassNames(self, className=None, recursive=False, qualified=False, sort=F
return self._ask(question='getClassNames', opt=opt)


class OMCPath(pathlib.PurePosixPath):
"""
Implementation of a basic Path object which uses OMC as backend. The connection to OMC is provided via a
OMCSessionZMQ session object.
"""

def __init__(self, *path, session: OMCSessionZMQ) -> None:
super().__init__(*path)
self._session = session

def with_segments(self, *pathsegments):
"""
Create a new OMCPath object with the given path segments.

The original definition of Path is overridden to ensure session is set.
"""
return type(self)(*pathsegments, session=self._session)

def is_file(self, *, follow_symlinks=True) -> bool:
"""
Check if the path is a regular file.
"""
return self._session.sendExpression(f'regularFileExists("{self.as_posix()}")')

def is_dir(self, *, follow_symlinks=True) -> bool:
"""
Check if the path is a directory.
"""
return self._session.sendExpression(f'directoryExists("{self.as_posix()}")')

def read_text(self, encoding=None, errors=None, newline=None) -> str:
"""
Read the content of the file represented by this path as text.

The additional arguments `encoding`, `errors` and `newline` are only defined for compatibility with Path()
definition.
"""
return self._session.sendExpression(f'readFile("{self.as_posix()}")')

def write_text(self, data: str, encoding=None, errors=None, newline=None):
"""
Write text data to the file represented by this path.

The additional arguments `encoding`, `errors`, and `newline` are only defined for compatibility with Path()
definitions.
"""
if not isinstance(data, str):
raise TypeError('data must be str, not %s' %
data.__class__.__name__)

return self._session.sendExpression(f'writeFile("{self.as_posix()}", "{data}", false)')

def mkdir(self, mode=0o777, parents=False, exist_ok=False):
"""
Create a directory at the path represented by this OMCPath object.

The additional arguments `mode`, and `parents` are only defined for compatibility with Path() definitions.
"""
if self.is_dir() and not exist_ok:
raise FileExistsError(f"Directory {self.as_posix()} already exists!")

return self._session.sendExpression(f'mkdir("{self.as_posix()}")')

def cwd(self):
"""
Returns the current working directory as an OMCPath object.
"""
cwd_str = self._session.sendExpression('cd()')
return OMCPath(cwd_str, session=self._session)

def unlink(self, missing_ok: bool = False) -> None:
"""
Unlink (delete) the file or directory represented by this path.
"""
res = self._session.sendExpression(f'deleteFile("{self.as_posix()}")')
if not res and not missing_ok:
raise FileNotFoundError(f"Cannot delete file {self.as_posix()} - it does not exists!")

def resolve(self, strict: bool = False):
"""
Resolve the path to an absolute path. This is done based on available OMC functions.
"""
if strict and not (self.is_file() or self.is_dir()):
raise OMCSessionException(f"Path {self.as_posix()} does not exist!")

if self.is_file():
omcpath = self._omc_resolve(self.parent.as_posix()) / self.name
elif self.is_dir():
omcpath = self._omc_resolve(self.as_posix())
else:
raise OMCSessionException(f"Path {self.as_posix()} is neither a file nor a directory!")

return omcpath

def _omc_resolve(self, pathstr: str):
"""
Internal function to resolve the path of the OMCPath object using OMC functions *WITHOUT* changing the cwd
within OMC.
"""
expression = ('omcpath_cwd := cd(); '
f'omcpath_check := cd("{pathstr}"); ' # check requested pathstring
'cd(omcpath_cwd)')

try:
result = self._session.sendExpression(command=expression, parsed=False)
result_parts = result.split('\n')
pathstr_resolved = result_parts[1]
pathstr_resolved = pathstr_resolved[1:-1] # remove quotes

omcpath_resolved = self._session.omcpath(pathstr_resolved)
except OMCSessionException as ex:
raise OMCSessionException(f"OMCPath resolve failed for {pathstr}!") from ex

if not omcpath_resolved.is_file() and not omcpath_resolved.is_dir():
raise OMCSessionException(f"OMCPath resolve failed for {pathstr} - path does not exist!")

return omcpath_resolved

def absolute(self):
"""
Resolve the path to an absolute path. This is done by calling resolve() as it is the best we can do
using OMC functions.
"""
return self.resolve(strict=True)

def exists(self, follow_symlinks=True) -> bool:
"""
Semi replacement for pathlib.Path.exists().
"""
return self.is_file() or self.is_dir()

def size(self) -> int:
"""
Get the size of the file in bytes - this is an extra function and the best we can do using OMC.
"""
if not self.is_file():
raise OMCSessionException(f"Path {self.as_posix()} is not a file!")

res = self._session.sendExpression(f'stat("{self.as_posix()}")')
if res[0]:
return int(res[1])

raise OMCSessionException(f"Error reading file size for path {self.as_posix()}!")


class OMCSessionZMQ:

def __init__(
Expand Down Expand Up @@ -322,6 +467,39 @@ def __del__(self):

self.omc_zmq = None

def omcpath(self, *path) -> OMCPath:
"""
Create an OMCPath object based on the given path segments and the current OMC session.
"""
return OMCPath(*path, session=self)

def omcpath_tempdir(self, tempdir_base: Optional[OMCPath] = None) -> OMCPath:
"""
Get a temporary directory using OMC. It is our own implementation as non-local usage relies on OMC to run all
filesystem related access.
"""
names = [str(uuid.uuid4()) for _ in range(100)]

if tempdir_base is None:
tempdir_str = self.sendExpression("getTempDirectoryPath()")
tempdir_base = self.omcpath(tempdir_str)

tempdir: Optional[OMCPath] = None
for name in names:
# create a unique temporary directory name
tempdir = tempdir_base / name

if tempdir.exists():
continue

tempdir.mkdir(parents=True, exist_ok=False)
break

if tempdir is None or not tempdir.is_dir():
raise OMCSessionException("Cannot create a temporary directory!")

return tempdir

def execute(self, command: str):
warnings.warn("This function is depreciated and will be removed in future versions; "
"please use sendExpression() instead", DeprecationWarning, stacklevel=2)
Expand Down
78 changes: 78 additions & 0 deletions tests/test_OMCPath.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
import sys
import OMPython
import pytest

skip_on_windows = pytest.mark.skipif(
sys.platform.startswith("win"),
reason="OpenModelica Docker image is Linux-only; skipping on Windows.",
)

skip_python_older_312 = pytest.mark.skipif(
sys.version_info < (3, 12),
reason="OMCPath(non-local) only working for Python >= 3.12.",
)


def test_OMCPath_OMCSessionZMQ():
om = OMPython.OMCSessionZMQ()

_run_OMCPath_checks(om)

del om


def test_OMCPath_OMCProcessLocal():
omp = OMPython.OMCProcessLocal()
om = OMPython.OMCSessionZMQ(omc_process=omp)

_run_OMCPath_checks(om)

del om


@skip_on_windows
@skip_python_older_312
def test_OMCPath_OMCProcessDocker():
omcp = OMPython.OMCProcessDocker(docker="openmodelica/openmodelica:v1.25.0-minimal")
om = OMPython.OMCSessionZMQ(omc_process=omcp)
assert om.sendExpression("getVersion()") == "OpenModelica 1.25.0"

_run_OMCPath_checks(om)

del omcp
del om


@pytest.mark.skip(reason="Not able to run WSL on github")
@skip_python_older_312
def test_OMCPath_OMCProcessWSL():
omcp = OMPython.OMCProcessWSL(
wsl_omc='omc',
wsl_user='omc',
timeout=30.0,
)
om = OMPython.OMCSessionZMQ(omc_process=omcp)

_run_OMCPath_checks(om)

del omcp
del om


def _run_OMCPath_checks(om: OMPython.OMCSessionZMQ):
p1 = om.omcpath_tempdir()
p2 = p1 / 'test'
p2.mkdir()
assert p2.is_dir()
p3 = p2 / '..' / p2.name / 'test.txt'
assert p3.is_file() is False
assert p3.write_text('test')
assert p3.is_file()
assert p3.size() > 0
p3 = p3.resolve().absolute()
assert str(p3) == str((p2 / 'test.txt').resolve().absolute())
assert p3.read_text() == "test"
assert p3.is_file()
assert p3.parent.is_dir()
p3.unlink()
assert p3.is_file() is False
Loading