Revert "CMake: Pass OpenMP compiler and linker flags through CMake targets"
#5413
+68
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
But why? What is the reason? People are building things based on these changes. |
|
Is this going to be dropped, in view of #5412 being closed? |
Collaborator
Author
|
closing of #5412 was a side effect of merging their mitigation proposal that at least removed the forced exit when multiple openmp libraries were suspected to be linked. I need to review if the other half of the PR was actually an improvement, but my primary focus right now is to merge my PR to fix the Apple M4 SME problems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5180 , fixes #5412