Update GEMM param for NEOVERSEV1 #4381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
approved these changes
Dec 19, 2023
Contributor
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
These seem sensible to me! Thanks @darshanp4 😸
Author
|
@Mousius thank you for review , much appreciated! 👍 |
Collaborator
|
Great, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue dgemm performance degradation on ARM NEOVERSEV1 with lower P*Q #4323 updated the SGEMM and DGEMM PQ param as per the configuration of NEOVERSEV1 cache size. Not keeping too big but enough to get better performance and close enough to half of the cache size.
Below is OpenBLAS/gemm.c benchmark on single core ( also seen on multicore) of graviton3 machine. Performance for SGEMM improved by ~ 2-5% and DGEMM improved by ~2-12%
@martin-frbg please help to get it review and merge.