Fixes for PGI compiler #2162
Merged
Fixes for PGI compiler #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes compile failure with pgi 18.10 as reported on OpenBLAS-users
Makefile.x86_64
Outdated
| ifeq ($(C_COMPILER), GCC) | ||
| CCOMMON_OPT += -mavx2 | ||
| endif | ||
| ifeq $(F_COMPILER), GFORTRAN) |
Contributor
There was a problem hiding this comment.
I was a bit curious why CI was only failing for manylinux1, but it looks like it is just a missing opening bracket here maybe?
Perhaps only observed on manylinux1 because of the crude CI build code I wrote there, but maybe that's useful for this kind of detection anyway.
Collaborator
Author
There was a problem hiding this comment.
Most likely it is just an older version of make with a different parser. But it is certainly good to have such a variety of systems available for CI.
PGI assembler does not like the initialization in the constraints.
martin-frbg
changed the title
This was referenced Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes compile failure with pgi 18.10 as reported on OpenBLAS-users