Some PHPStan fixes #3031
Merged
Some PHPStan fixes #3031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I was checking some more but they're super hard to test/fix... |
github-actions
bot
added
Component: lib/Varien
addison74
previously approved these changes
Feb 18, 2023
tmotyl
reviewed
Feb 22, 2023
tmotyl
reviewed
Feb 23, 2023
tmotyl
reviewed
Feb 23, 2023
fballiano
commented
Feb 23, 2023
fballiano
commented
Feb 23, 2023
fballiano
commented
Feb 23, 2023
kiatng
reviewed
Mar 16, 2023
kiatng
reviewed
Mar 16, 2023
kiatng
reviewed
Mar 16, 2023
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
kiatng
reviewed
Mar 16, 2023
Co-authored-by: Ng Kiat Siong <[email protected]>
kiatng
reviewed
Mar 17, 2023
kiatng
previously approved these changes
Mar 18, 2023
Contributor
Author
|
sorry @kiatng, I'd to fix 2 phpcs errors :-\ |
kiatng
approved these changes
Mar 18, 2023
elidrissidev
approved these changes
Mar 18, 2023
fballiano
added a commit
that referenced
this pull request
Mar 18, 2023
* PHPStan fix in app/Mage.php * Solved PHPStan problems with lib/Varien/Object/Cache.php * PHPStan fixes for lib/Varien/Object/Mapper.php * PHPStan fixes for lib/Varien/Io/File.php * Fixed PHPStan error for lib/Varien/Image/Adapter/Gd2.php * Fixed signature for getSingleton * removed what this PR fixed * Update lib/Varien/Io/File.php * Update lib/Varien/Object/Cache.php * seems not necessary anymore * seems not necessary anymore * updates * updates * updates * revert * trying to fix the baseline * trying to fix the baseline * failed comparisons * types * test type hint * typehint * nullable * fixes * fixes * small revert * small revert * better error message * Update app/code/core/Mage/Adminhtml/Block/System/Config/Form.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Paypal/Controller/Express/Abstract.php Co-authored-by: Ng Kiat Siong <[email protected]> * suggestion * Update app/code/core/Mage/Adminhtml/Block/System/Config/Form.php Co-authored-by: Ng Kiat Siong <[email protected]> * Exception added * small rewrite * phpcs --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Contributor
Author
|
merged and v20ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.