Skip to content

feat: enable skywalking plugin for tracing #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 4, 2022
Merged

feat: enable skywalking plugin for tracing #86

merged 13 commits into from
Sep 4, 2022

Conversation

@YADROOKIE
Copy link

@YADROOKIE YADROOKIE commented Aug 29, 2022

#47

@auto-assign auto-assign bot requested a review from benjaminhuo August 29, 2022 06:35
@mergeable
Copy link

mergeable bot commented Aug 29, 2022

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@YADROOKIE YADROOKIE marked this pull request as draft August 29, 2022 06:36
@webup webup requested review from webup and removed request for benjaminhuo August 29, 2022 06:41
@webup webup added the type: feature New feature or request label Aug 29, 2022
@YADROOKIE YADROOKIE marked this pull request as ready for review September 1, 2022 11:53
@auto-assign auto-assign bot requested a review from benjaminhuo September 1, 2022 11:53
@YADROOKIE YADROOKIE marked this pull request as draft September 1, 2022 11:53
@webup
Copy link
Collaborator

webup commented Sep 2, 2022

LGTM, basically.

@YADROOKIE please help verify this feature via function and plugin bundle image over K8s as well, thanks.

@webup webup marked this pull request as ready for review September 2, 2022 04:42
@benjaminhuo
Copy link
Member

benjaminhuo commented Sep 2, 2022

Great efforts! Thanks, @YADROOKIE @webup Nodejs functions framework has become the most well-supported and active functions framework of OpenFunction!

@webup webup changed the title Feature/skywalking plugin for tracing feat: enable skywalking plugin for tracing Sep 4, 2022
@webup webup merged commit 32672fa into OpenFunction:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webup webup Awaiting requested review from webup

@benjaminhuo benjaminhuo Awaiting requested review from benjaminhuo

Assignees

@YADROOKIE YADROOKIE

Labels

type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YADROOKIE @webup @benjaminhuo