Skip to content

Conversation

@Bahati308
Copy link
Contributor

@Bahati308 Bahati308 commented Dec 15, 2025

Pull Request Title

Feat: Formulus/formplayer checks

Description

Type of Change

  • Bug Fix
  • New Feature / Enhancement
  • Refactor / Code Cleanup
  • Documentation Update
  • Maintenance / Chore
  • Other (CI/CD):

Component(s) Affected

  • formulus (React Native mobile app)
  • formulus-formplayer (React web app)
  • synkronus (Go backend server)
  • synkronus-cli (Command-line utility)
  • Documentation
  • DevOps / CI/CD
  • Other:

Related Issue(s)

Closes/Fixes/Resolves:
closes #72

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manually tested
  • Tested on multiple platforms (if applicable)
  • Not applicable

Breaking Changes

  • This PR introduces breaking changes
  • This PR does NOT introduce breaking changes

If breaking changes, please describe migration steps:


Documentation Updates

  • Documentation has been updated
  • Documentation update is not required

Checklist

  • Code follows project style guidelines
  • All existing tests pass
  • New tests added for new functionality
  • PR title follows Conventional Commits format

@Bahati308 Bahati308 changed the title Fix 60 Feat: Formulus/formplayer checks Dec 15, 2025
@Bahati308 Bahati308 marked this pull request as ready for review December 15, 2025 20:23
Copy link
Contributor

@r0ssing r0ssing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks really good (I reckon this is mostly the prettier format changes, so I didn't look through all the files in detail ;-))

"scripts": {
"start": "react-scripts start",
"sync-interface": "powershell -NoProfile -Command \"Copy-Item -Path '../formulus/src/webview/FormulusInterfaceDefinition.ts' -Destination './src/FormulusInterfaceDefinition.ts' -Force\"",
"sync-interface": "node scripts/sync-interface.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! We could even imagine also sync'ing the style tokens or other things here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I kept the scope limited for this PR, but the Node-based script makes it straightforward to extend later for syncing style tokens or similar shared resources.

@Bahati308
Copy link
Contributor Author

Bahati308 commented Dec 16, 2025

Thanks! This looks really good (I reckon this is mostly the prettier format changes, so I didn't look through all the files in detail ;-))

Thanks! Yes, this is primarily Prettier-driven formatting with no functional changes.

@Bahati308 Bahati308 merged commit 8db7e62 into OpenDataEnsemble:dev Dec 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Formatting/Linting for Formulus and form player

2 participants