-
Notifications
You must be signed in to change notification settings - Fork 8
Feat: Formulus/formplayer checks #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r0ssing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks really good (I reckon this is mostly the prettier format changes, so I didn't look through all the files in detail ;-))
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "sync-interface": "powershell -NoProfile -Command \"Copy-Item -Path '../formulus/src/webview/FormulusInterfaceDefinition.ts' -Destination './src/FormulusInterfaceDefinition.ts' -Force\"", | ||
| "sync-interface": "node scripts/sync-interface.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor! We could even imagine also sync'ing the style tokens or other things here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I kept the scope limited for this PR, but the Node-based script makes it straightforward to extend later for syncing style tokens or similar shared resources.
Thanks! Yes, this is primarily Prettier-driven formatting with no functional changes. |
Pull Request Title
Feat: Formulus/formplayer checks
Description
Type of Change
Component(s) Affected
Related Issue(s)
Closes/Fixes/Resolves:
closes #72
Testing
Breaking Changes
If breaking changes, please describe migration steps:
Documentation Updates
Checklist