-
Notifications
You must be signed in to change notification settings - Fork 8
feat: modernize UI with MUI and ODE tokens #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Implement Material Design 3 theme with ODE token integration - Modernize buttons: pill-shaped, proper elevation, 48dp touch targets - Update inputs: 4px radius, improved focus states, 56dp min height - Apply ODE brand colors (green primary, gold secondary) - Centralize styling in theme for consistent application - Ensure accessibility: WCAG contrast, proper focus, touch targets.
IamLRBA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice going @Bahati308, this is actually one of the deliverables of the unified design sytem for ODE and comes at a perfect time. The theme integration, accessibility improvements (48dp touch targets), and component updates all look good.
Just One Issue: I think the local tokens.ts file you created duplicates token values. If @ode/tokens is already in package.json of `formulus-formplayer, we should import directly from the original tokens package instead.
Suggested fix:
Maybe we can replace the local tokens.ts file with direct imports from the package:
In theme.ts, change from:
import { tokens } from './tokens';
To:
import tokens from '@ode/tokens/dist/js/tokens';
This keeps tokens in sync automatically from the original source and avoids duplication. Create React App should handle imports from node_modules after npm install.
Lastly, we might also consider adding the CSS import to index.css for CSS variable support:
@import '@ode/tokens/dist/css/tokens.css';
Thanks again for the improvements mate!
|
I really love this initiative you have put in this! |
thanks for the insight @IamLRBA , lemme improve accordingly. |
This file adapts the @ode/tokens JSON export to the expected structure for theme.ts, transforming font properties to typography and parsing pixel values.
|
@Bahati308, based on the suggestion, I made some changes please have a look. SummaryI fixed the token duplication issue by replacing the local Changes Made
Setup StepsAfter pulling these changes, run the following to update # Build the tokens package first
cd packages/tokens
npm install
npm run build
# Then install dependencies in formulus-formplayer (this will auto-generate package-lock.json)
cd ../../formulus-formplayer
npm install
# Start the development server
npm startThe Benefits
Note: I tested this works and the development server started successfully showing the use of token for the UI |
Screen.Recording.2025-12-14.at.20.22.34.movthis is super dope, @IamLRBA, even Formulus can testify |
IamLRBA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the tokens are being reflected in Formulus as well
Nice going @Bahati308
closes #9