Formplayer bug fix #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nderer Replace NodeJS.Timeout with ReturnType<typeof setInterval> to fix TypeScript compilation error on macOS. This ensures cross-platform compatibility between browser (number) and Node.js (Timeout) timer types. Fixes OpenDataEnsemble#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Replaced use of NodeJS.Timeout with ReturnType in AudioQuestionRenderer. This change makes the timer type compatible with browsers (where setInterval returns a numeric ID), fixing a TypeScript compilation error on macOS.
Why this happens:
setIntervalreturns a NodeJS.Timeout object.setIntervalreturns a number (the ID of the timer).Why this is needed
The previous use of NodeJS.Timeout caused a type mismatch in browser environments — most end‑users of ODE (particularly formplayer) expect to run in browsers (not Node), so this prevented successful builds / bundling for browser targets.
Ensures cross‑platform compatibility (Node + browser), which aligns with ODE’s (particularly formplayer)design goal of being usable in mobile/offline‑first or web environments.
Related issue / context
Fixes #50