-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add authentication flow and bottom tab navigation #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add authentication flow and bottom tab navigation #49
Conversation
|
Hello @najuna-brian, thanks for the great input. In my opinion, we could keep the sign-in page content configurable through the settings, and introduce a separate user authentication flow where users can create an account and log in using their own credentials. |
|
Thanks! This looks great😎! I believe we have a version of the logo with transparent background somewhere (but I'm out of office these days, so I will check that when I'm back, in case that looks smoother?) As for use creation, my initial thought is to do that through the web portal or the CLI? |
|
Looks great. I love the updated look and menu. I think I also agree with emil that we could still have user creation via synkronus portal or CLI and then the login to be via the settings. |
|
@r0ssing, @Mishael-2584 |
Thanks, In the changes i have made, i have considered this, and also making sure features are available based on user role registered from the cli/synkronus portal |
|
Hi @Ndacyayisenga-droid Would it need change to the workflow permissions to Enable "Allow GitHub Actions to create and approve pull requests" This enables automated PR labeling while keeping other permissions restricted. The failure isn't blocking the merge, but the fix would enable this workflow going forward. |
r0ssing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This looks great!! 👌 I also really like that you added a button for observations - we can definitely so something interesting work that screen (general statistics or something)
Description
Implements authentication flow and navigation structure for Formulus mobile app.
Changes
Testing
the colours and other customizations will be adopted when the tokens have been merged
Closes #47