Skip to content

fix: handle root-level forms/ext.json in bundle validation #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ndacyayisenga-droid merged 1 commit into from
Jan 21, 2026
Merged

fix: handle root-level forms/ext.json in bundle validation #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions synkronus-cli/pkg/validation/bundle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ func ValidateBundle(bundlePath string) error {
// Track form directories (exclude ext.json files)
if strings.HasPrefix(file.Name, "forms/") && !strings.HasSuffix(file.Name, "/") {
// Skip ext.json files - they're not form directories
if strings.HasSuffix(file.Name, "/ext.json") {
// Skip both root-level (forms/ext.json) and form-level (forms/{formName}/ext.json)
if file.Name == "forms/ext.json" || strings.HasSuffix(file.Name, "/ext.json") {
continue
}
formParts := strings.Split(file.Name, "/")
Expand All @@ -81,7 +82,8 @@ func ValidateBundle(bundlePath string) error {
// Validate form structure
if strings.HasPrefix(file.Name, "forms/") {
// Skip ext.json files - they're validated separately in validateExtensions
if strings.HasSuffix(file.Name, "/ext.json") {
// Skip both root-level (forms/ext.json) and form-level (forms/{formName}/ext.json)
if file.Name == "forms/ext.json" || strings.HasSuffix(file.Name, "/ext.json") {
continue
}
if err := validateFormFile(file); err != nil {
Expand Down Expand Up @@ -180,7 +182,8 @@ func validateFormRendererReferences(zipReader *zip.Reader) error {

// Second, collect extension renderers from ext.json files
for _, file := range zipReader.File {
if strings.HasSuffix(file.Name, "/ext.json") {
// Collect both root-level (forms/ext.json) and form-level (forms/{formName}/ext.json) ext.json files
if file.Name == "forms/ext.json" || strings.HasSuffix(file.Name, "/ext.json") {
rc, err := file.Open()
if err != nil {
continue // Skip if can't open
Expand Down Expand Up @@ -413,7 +416,8 @@ func validateExtensions(zipReader *zip.Reader) error {

// First pass: collect extension files and validate structure
for _, file := range zipReader.File {
if strings.HasSuffix(file.Name, "/ext.json") {
// Collect both root-level (forms/ext.json) and form-level (forms/{formName}/ext.json) ext.json files
if file.Name == "forms/ext.json" || strings.HasSuffix(file.Name, "/ext.json") {
extensionFiles[file.Name] = file

// Validate JSON structure
Expand Down
Loading