-
Notifications
You must be signed in to change notification settings - Fork 8
ci: automate formplayer build and bundle in Android workflow #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add automatic formplayer build and bundling to CI/CD pipeline. Developers can now push formplayer changes directly without manual bundling - CI handles build, bundle, and Android APK generation.
|
Hi @Bahati308 I have added a description to the issue for this PR, you can please have a look here This PR looks like it builds and copies assets during CI, but only for the APK build, not for persisting the assets in |
|
The workflow builds assets but doesn't persist them. Could we add a git commit step after the build to push assets to formulus, ensuring local developers get latest changes on pull. Thoughts? |
|
Hello. Thank you for this! It will really help us ensure consistency and eliminate human error from this part.. |
Add automated workflow to build and commit formplayer assets when formulus-formplayer changes are merged, eliminating manual sync PRs. - Add update-formplayer-assets.yml workflow for automatic asset updates - Simplify upload:android script (remove redundant cleaning) - Ignore asset-only commits in Android build workflow Refs: OpenDataEnsemble#233
Thanks for the great review @najuna-brian , it was insightful and the updates have everything up and running. |
r0ssing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
r0ssing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backmerged..
Automate formplayer build and bundle in CI/CD workflow
Description
Add automated workflow to build and commit formplayer assets when formulus-formplayer
changes are merged to main/dev branches, eliminating manual synchronization PRs.
Changes:
This eliminates the need for developers to manually:
The CI now handles the entire asset synchronization process:
Type of Change
Component(s) Affected
Related Issue(s)
Closes/Fixes/Resolves:
closes #233
Testing
Breaking Changes
If breaking changes, please describe migration steps:
Documentation Updates
Checklist
Thank you for contributing to Open Data Ensemble (ODE)!