fix(formplayer): Fix JSONForms cell rendering and add HTML label support #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove shell wrappers from material controls that were breaking JSONForms internal cell rendering mechanism (fixes crash when swiping form pages) - Add HtmlLabelRenderer to properly render HTML in Label elements - Add HTML sanitization to QuestionShell for title/description fields - Remove unused dompurify dependency (using built-in sanitizer) - Clean up debug logging from App.tsx and SwipeLayoutRenderer.tsx
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
najuna-brian
approved these changes
Dec 31, 2025
Contributor
There was a problem hiding this comment.
Great work @Mishael-2584
I like that in this PR you have solved the scrolling issue that have tested it on Formulus and it works well.
The entire hh_person form runs well end to end with the section having html rendering well. This is good work 🤝
Ndacyayisenga-droid
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove shell wrappers from material controls that were breaking JSONForms internal cell rendering mechanism (fixes crash when swiping form pages)
Add HtmlLabelRenderer to properly render HTML in Label elements
Add HTML sanitization to QuestionShell for title/description fields
Remove unused dompurify dependency (using built-in sanitizer)
Clean up debug logging from App.tsx and SwipeLayoutRenderer.tsx
Pull Request Title
Description
Type of Change
Component(s) Affected
Related Issue(s)
Closes/Fixes/Resolves:
Testing
Breaking Changes
If breaking changes, please describe migration steps:
Documentation Updates
Checklist
Thank you for contributing to Open Data Ensemble (ODE)!