-
Notifications
You must be signed in to change notification settings - Fork 10
Add RPC service support to the RX pipeline #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thirtytwobits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the comment about the documented ownership model is blocking here. The rest of the comments are minor.
|
Kudos, SonarCloud Quality Gate passed!
|









This is the final feature.
This changeset slightly modifies the error handling behavior of
udpardRxSubscriptionReceivesuch that the datagram is deallocated if the passed arguments are invalid, unlessselfis also invalid. This is needed to prevent memory leak when the function is invoked incorrectly. An alternative solution is to state it explicitly in the API that the caller is required to free the datagram memory if-UDPARD_ERROR_ARGUMENTis returned, but this convention is comparatively fragile. A new test is added for this.UdpardRxRPCis renamed intoUdpardRxRPCPortfor clarity.UdpardRxRPCDispatcheris extended withlocal_node_idto facilitate destination address check when accepting frames.After this one is accepted, the next steps are: