Add nullable annotation support to AspNetCoreServer #9620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since c# 8 / .net core 3.0 it is possible to add a nullable annotation to a project file.
This allows to use the ? annotation not only on non-nullable types but on all types.
Using this annotations can improve the readability within the code and also improves API behavior in regards to optional (nullable) properties.
The default behavior is not altered, it should stay compatible with everything.
Tests were added to ensure correct behavior.
This PR is a possible solution for:
#9190
#9022
@shibayan @Blackclaws @lucamazzanti
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x