Skip to content

Conversation

jmini
Copy link
Member

@jmini jmini commented Jul 18, 2018

Follow up from #588

@jmini jmini added this to the 3.1.2 milestone Jul 18, 2018
@jmini jmini mentioned this pull request Jul 18, 2018
README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep this line for 3.1.2-SNAPSHOT?

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change reverts 3.1.1 back to 3.1.0. Same for the other 2 line changes below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1.1 reverts back to 3.1.0

@jmini jmini force-pushed the prepare_312-snapshot branch from 2402b56 to 5e7009b Compare July 18, 2018 08:49
@jmini
Copy link
Member Author

jmini commented Jul 18, 2018

I have forced push my second commit that was containing to much changes (as pointed out by the review). It should be good now.

Thank you a lot for catching this!

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jmini jmini merged commit 1e59649 into master Jul 18, 2018
@jmini jmini deleted the prepare_312-snapshot branch July 18, 2018 09:49
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants