Skip to content

Conversation

GabJac
Copy link

@GabJac GabJac commented Nov 19, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)

Description of the PR

Changed the return type to a blob instead of json when the response type is a file.

@macjohnny
Copy link
Member

@GabJac did you generate the samples and commit them?
Moreover, I believe it has already been resolved with #569 by @Place1
However, this PR is still useful, as it adds file support in the 3.x version.

@GabJac
Copy link
Author

GabJac commented Nov 19, 2018

@macjohnny i did generate the samples but there was no change in them since there is no response of type file.

@macjohnny
Copy link
Member

@GabJac thanks for checking. If nothing has changed, then it is fine.
I found a similar PR #1367. The main difference that I found is that it also reads the file name and modification date from the header and returns a File instance instead of a blob, am I right @spallister?
Maybe @TiFu @Place1 can give their opinion which of the two to use for 3.x.x?

@spallister
Copy link

Hey @macjohnny - Right you are.

@wing328
Copy link
Member

wing328 commented Nov 24, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 modified the milestones: 3.3.4, 4.0.0 Nov 24, 2018
@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328 wing328 modified the milestones: 4.0.3, 4.1.0 Jul 9, 2019
@wing328 wing328 modified the milestones: 4.1.0, 4.1.1 Aug 9, 2019
@wing328 wing328 modified the milestones: 4.1.1, 4.1.2 Aug 26, 2019
@wing328 wing328 modified the milestones: 4.1.2, 4.1.3 Sep 11, 2019
@wing328 wing328 modified the milestones: 4.1.3, 4.2.0 Oct 4, 2019
@wing328 wing328 removed this from the 4.2.0 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants