[Java-okhttp-gson] Do not set content-type if content type is null #11315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
PR contents
If an API does not define a custom ContentType, an empty Content-Type: header is generated. Some servers do not like this and respond with HTTP status 400. If the Content-Type header is ommited completely in this situation, the connection is working again.
In PR #11199 a fix was attempted, however I do not think it solves the underlying problem. I think the main problem is a typo, which mixed up the variables
localVarHeaderParamsandlocalVarContentType. TheselectHeaderContentTypemethod return null if there islocalVarContentTypesis empty and no default content type should be used.The expression
localVarContentType != nullis always true, since the variable is properly initialized some lines earlier. The same goes forlocalVarContentTypes != null.