Skip to content

Conversation

@mvistein
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

PR contents

If an API does not define a custom ContentType, an empty Content-Type: header is generated. Some servers do not like this and respond with HTTP status 400. If the Content-Type header is ommited completely in this situation, the connection is working again.

In PR #11199 a fix was attempted, however I do not think it solves the underlying problem. I think the main problem is a typo, which mixed up the variables localVarHeaderParams and localVarContentType. The selectHeaderContentType method return null if there is localVarContentTypes is empty and no default content type should be used.
The expression localVarContentType != null is always true, since the variable is properly initialized some lines earlier. The same goes for localVarContentTypes != null.

@wing328
Copy link
Member

wing328 commented Jan 16, 2022

cc @MarcMil as well (author of #11199)

@wing328
Copy link
Member

wing328 commented Jan 16, 2022

@mvistein thanks for the fix. I think you're right. localVarContentType should be used instead.

@wing328 wing328 merged commit c12456d into OpenAPITools:master Jan 16, 2022
@wing328 wing328 changed the title [Java-okhttp-gson] Do not set content-type if content type is null #2 [Java-okhttp-gson] Do not set content-type if content type is null Jan 28, 2022
@mvistein mvistein deleted the fix-java-generator branch March 7, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants