Skip to content

[typescript-fetch] (4.0.X) format: date parameters should not include time component #1561

@someone1

Description

@someone1
Description

Currently, when a request is generated via the typescript-fetch client, type: string/format:date parameters include a time component when it should not.

openapi-generator version

openapi-generator-cli-4.0.0-20181126.024631-44

OpenAPI declaration file content or url
swagger: "2.0"
info:
  title: "Simple Test"

paths:
  "/get/Simple":
    get:
      summary: Retrieve List of Simple
      operationId: "get.Simple"
      responses:
        200:
          description: OK
          schema:
            $ref: "#/definitions/Simple"

definitions:         
  Simple:
    type: object
    required:
      - Name
    properties:
      Date:
        type: string
        format: date

Output:

import { exists } from '../runtime';
/**
 * 
 * @export
 * @interface Simple
 */
export interface Simple {
    /**
     * 
     * @type {Date}
     * @memberof Simple
     */
    date?: Date;
}

export function SimpleFromJSON(json: any): Simple {
    return {
        'date': !exists(json, 'Date') ? undefined : new Date(json['Date']),
    };
}

export function SimpleToJSON(value?: Simple): any {
    if (value === undefined) {
        return undefined;
    }
    return {
        'Date': value.date === undefined ? undefined : value.date.toISOString(),
    };
}
Command line used for generation

openapi-generator generate -i openapi.yaml -l typescript-fetch -c es6.json -o ./typescript-api/

Steps to reproduce
  1. Use the provided yaml excerpt above to generate a client with the provided command line
  2. Buggy code generated
Related issues/PRs

PR #569

Suggest a fix/enhancement

Update template to take substring of ISO date to only include the date portion when format: date

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions