[typescript-fetch] (4.0.X) Missing queryParameters initialization

[someone1]

Description

Testing out the updated generator from PR #569 and I noticed an issue where I have multiple authentication requirements for an API endpoint (logical AND - both required) for an API key via query parameter and via an Authorization header. The generated code places both in correctly, however, for endpoints where I otherwise have no other query parameters (e.g. the authentication method is the only one), the variable queryParameters is never defined and its not passed in to the request.

openapi-generator version

4.0.0-20181118.115720-41

OpenAPI declaration file content or url (partial)

swagger: "2.0"

paths:
  "/admin/users/{id}/clearTokens":
    post:
      operationId: "users.clear_tokens"
      responses:
        204:
          description: Success
      parameters:
        - in: path
          name: id
          required: true
          type: string
      security:
        - google_id_token: []
          api_key: []

securityDefinitions:
  api_key:
    type: "apiKey"
    name: "key"
    in: "query"
  google_id_token:
    authorizationUrl: "https://accounts.google.com/o/oauth2/v2/auth"
    flow: "implicit"
    type: "oauth2"

Generated Code excerpt:

async usersClearTokensRaw(requestParameters: UsersClearTokensRequest): Promise<runtime.ApiResponse<void>> {
        if (requestParameters.id === null || requestParameters.id === undefined) {
            throw new runtime.RequiredError('id','Required parameter requestParameters.id was null or undefined when calling usersClearTokens.');
        }

        const headerParameters: runtime.HTTPHeaders = {};

        if (this.configuration && this.configuration.apiKey) {
            queryParameters["key"] = this.configuration.apiKey("key"); // api_key authentication
        }

        if (this.configuration && this.configuration.accessToken) {
            // oauth required
            if (typeof this.configuration.accessToken === 'function') {
                headerParameters["Authorization"] = this.configuration.accessToken("google_id_token", []);
            } else {
                headerParameters["Authorization"] = this.configuration.accessToken;
            }
        }

        const response = await this.request({
            path: `/admin/users/{id}/clearTokens`.replace(`{${"id"}}`, encodeURIComponent(String(requestParameters.id))),
            method: 'POST',
            headers: headerParameters,
        });

        return new runtime.VoidApiResponse(response);
    }

Command line used for generation

openapi-generator generate -i openapi.yaml -l typescript-fetch -c es6.json -o ./typescript-api/

Steps to reproduce

1. Use the provided yaml excerpt above to generate a client with the provided command line
2. Buggy code generated

Related issues/PRs

PR #569

Suggest a fix/enhancement

Template variable #hasQueryParams should be set to true if an authentication method required for that endpoint uses query parameters.

[macjohnny]

@someone1 thanks for reporting. would you like to give it a try and fix the code? maybe @Place1 could give a hand.

[someone1]

I wouldn't mind but I honestly don't know how this tool is designed and am not sure if the fix I proposed would even be the right approach. If the code to parse and set the template variables is shared between all generators, then wouldn't making this change affect all implementations?

I honestly don't know when I'd get the time to try and tackle this, let alone setup my local dev environment for the project and read through the code for where this is set. If any hints can be provided that can certainly help accelerate things. If I think I have time to tackle this and the issue is still open, I'll be sure to give it a try.

[someone1]

Actually, an alternative and easier approach might be to modify the mustache template to treat queryParameters like headerParameters in that it's always assumed to be required (there is no conditional surrounding the inclusion of headerParameters).

This is a fix I can implement fairly quickly.