[BUG] [Python] Handling objects as dictionnaries not working in 6.2.1

[OmarBouslama]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

We have an Event model in OpenAPI that contains these fields:

    Event:
      type: object
      x-examples:
        example-1:
          name: watched_trailer
          occuredAt: '2013-07-16T19:20:30+1:00'
          properties: {}
      properties:
        name:
          type: string
        occuredAt:
          type: string
        properties:
          type: object
      required:
        - name
        - occuredAt

Using generator version 5.x.x, I was able to init the model this way in Python:
event = Event(name="xxx", occuredAt="2020-06-01", properties={"prop1": "value1"})

However, using the 6.2.1 version
we have this stack trace now

nothing has changed except using a new open API generator version

  File "/usr/local/lib/python3.10/site-packages/crm_client/model/update_customer_v1_request.py", line 318, in __new__
    return super().__new__(
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 2990, in __new__
    return super().__new__(cls, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 621, in __new__
    return __new_cls._get_new_instance_without_conversion_oapg(
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 490, in _get_new_instance_without_conversion_oapg
    properties = cls._get_properties_oapg(arg, path_to_item, path_to_schemas)
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 2133, in _get_properties_oapg
    new_value = property_cls._get_new_instance_without_conversion_oapg(
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 493, in _get_new_instance_without_conversion_oapg
    items = cls._get_items_oapg(arg, path_to_item, path_to_schemas)
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 1822, in _get_items_oapg
    new_value = item_cls._get_new_instance_without_conversion_oapg(
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 490, in _get_new_instance_without_conversion_oapg
    properties = cls._get_properties_oapg(arg, path_to_item, path_to_schemas)
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 2133, in _get_properties_oapg
    new_value = property_cls._get_new_instance_without_conversion_oapg(
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 490, in _get_new_instance_without_conversion_oapg
    properties = cls._get_properties_oapg(arg, path_to_item, path_to_schemas)
  File "/usr/local/lib/python3.10/site-packages/crm_client/schemas.py", line 2133, in _get_properties_oapg
    new_value = property_cls._get_new_instance_without_conversion_oapg(
AttributeError: type object 'DynamicSchema' has no attribute '_get_new_instance_without_conversion_oapg'

openapi-generator version

6.2.1

OpenAPI declaration file content or url

Generation Details

Steps to reproduce

Add a model with that contains an object, generate the code and try to init the model by passing a dictionary to the object property
`AnyModel(some_field="value", object_property={"toto": "tata"})

Related issues/PRs

Suggest a fix

[spacether]

Hi there. I am unable to replicate your issue.
Here are the steps that I followed:
Using this spec:

openapi: 3.0.0
info:
  version: 1.0.0
  title: issue 13997 spec
  license:
    name: Apache-2.0
    url: 'https://www.apache.org/licenses/LICENSE-2.0.html'
servers: []
tags: []
paths: {}
components:
  schemas:
    Event:
      type: object
      x-examples:
        example-1:
          name: watched_trailer
          occuredAt: '2013-07-16T19:20:30+1:00'
          properties: {}
      properties:
        name:
          type: string
        occuredAt:
          type: string
        properties:
          type: object
      required:
        - name
        - occuredAt

I generated a 6.2.1 client:
docker run --rm -v "${PWD}:/local" openapitools/openapi-generator-cli:v6.2.1 generate -i /local/issue_13997.yaml -g python -o /local/python_out/

Then I created a python 3 (3.7.12) virtual environment and installed the library into it.
Then I ran this sample successfuly

from openapi_client.model import event
inst = event.Event(name="xxx", occuredAt="2020-06-01", properties={"prop1": "value1"})

Then I successfully repeated the same steps with python 3.10.1
So unfortunately I can't replicate your issue.

Can you provide more detailed steps to demonstrate the problem?

[Linux13524]

Hi @spacether. I can reproduce the issue with the following spec:

openapi: 3.0.0
info:
  version: 1.0.0
  title: issue 13997 spec
  license:
    name: Apache-2.0
    url: 'https://www.apache.org/licenses/LICENSE-2.0.html'
servers: []
tags: []
paths: {}
components:
  schemas:
    EventRequest:
      type: object
      required:
        - event
      properties:
        event:
          $ref: '#/components/schemas/Event'
    Event:
      type: object
      properties:
        name:
          type: string
        occuredAt:
          type: string
        properties:
          type: object

I generated the client then similar how you did:

docker run --rm -v "${PWD}:/local" openapitools/openapi-generator-cli:v6.2.1 generate -i /local/openapi-test.yaml -g python -o /local/python_out/

Running the following does work:

>>> from openapi_client.model.event import Event
>>> from openapi_client.model.event_request import EventRequest
EventRequest(event=Event(name="test", properties={}))

But running this does not:

>>> from openapi_client.model.event import Event
>>> from openapi_client.model.event_request import EventRequest
>>> EventRequest(event=Event(name="test", properties={"name": "test"}))

Resulting in a similar error that @OmarBouslama reported:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/openapi/python_out/openapi_client/model/event_request.py", line 80, in __new__
    return super().__new__(
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 2439, in __new__
    return super().__new__(cls, *args, **kwargs)
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 532, in __new__
    return __new_cls._get_new_instance_without_conversion_oapg(
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 436, in _get_new_instance_without_conversion_oapg
    properties = cls._get_properties_oapg(arg, path_to_item, path_to_schemas)
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 1707, in _get_properties_oapg
    new_value = property_cls._get_new_instance_without_conversion_oapg(
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 436, in _get_new_instance_without_conversion_oapg
    properties = cls._get_properties_oapg(arg, path_to_item, path_to_schemas)
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 1707, in _get_properties_oapg
    new_value = property_cls._get_new_instance_without_conversion_oapg(
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 436, in _get_new_instance_without_conversion_oapg
    properties = cls._get_properties_oapg(arg, path_to_item, path_to_schemas)
  File "/home/user/openapi/python_out/openapi_client/schemas.py", line 1707, in _get_properties_oapg
    new_value = property_cls._get_new_instance_without_conversion_oapg(
AttributeError: type object 'DynamicSchema' has no attribute '_get_new_instance_without_conversion_oapg'

[spacether]

A work around for your issue for now is to not pass in model instances into __new__ or from_openapi_data

from openapi_client.model.event_request import EventRequest
EventRequest(event={name="test", properties={"name": "test"}})

[spacether]

All fixed :)