Skip to content

Fix/issue 66 wrong return in ref pointer #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quen2404 merged 2 commits into from
Feb 20, 2019
Merged

Fix/issue 66 wrong return in ref pointer #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67997a1
fix(utils): replace return in RefPointer
quen2404 Feb 20, 2019
5273669
format(output): reformat markdown renderer according google format
quen2404 Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/qdesrame/openapi/diff/compare/SchemaDiff.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ protected static Schema resolveComposedSchema(Components components, Schema sche
return schema;
}

protected static Schema addSchema(Schema schema, Schema fromSchema) {
protected static Schema addSchema(Schema<?> schema, Schema<?> fromSchema) {
if (fromSchema.getProperties() != null) {
if (schema.getProperties() == null) {
schema.setProperties(fromSchema.getProperties());
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/qdesrame/openapi/diff/output/MarkdownRender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ protected String itemResponse(String title, String code, String description) {
protected String headers(ChangedHeaders headers) {
StringBuilder sb = new StringBuilder();
if (headers != null) {
sb.append(listHeader("New header", headers.getIncreased()));
sb.append(listHeader("Deleted header", headers.getMissing()));
sb.append(listHeader("New header", headers.getIncreased()))
.append(listHeader("Deleted header", headers.getMissing()));
headers
.getChanged()
.entrySet()
Expand Down
8 changes: 1 addition & 7 deletions src/main/java/com/qdesrame/openapi/diff/utils/RefPointer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,16 @@ private Map<String, T> getMap(Components components) {
switch (refType) {
case REQUEST_BODIES:
return (Map<String, T>) components.getRequestBodies();

case RESPONSES:
return (Map<String, T>) components.getResponses();

case PARAMETERS:
return (Map<String, T>) components.getParameters();

case SCHEMAS:
return (Map<String, T>) components.getSchemas();

case HEADERS:
return (Map<String, T>) components.getSchemas();

return (Map<String, T>) components.getHeaders();
case SECURITY_SCHEMES:
return (Map<String, T>) components.getSecuritySchemes();

default:
throw new IllegalArgumentException("Not mapped for refType: " + refType);
}
Expand Down