fix: Rare User and Subscription creates and updates processing out of order (introduced in 5.4.0) #2419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix rare bugs with User and Subscription creates and updates processing out of order that was introduced in 5.4.0.
Details
Made a new internal coroutine scope with a single thread to the OperationRepo to ensure operations are alway executed in the order they are queued in.
This mostly fixes the flaky OperationRepoTest class.
Release 5.4.0 may have introduced bugs related to this, however they would have been rare and very hard to reproduce.
enqueueAndWaitcould have been out of order, it wasn't being put on the same scope asenqueue.Motivation
The original motivation was to fix flaky OperationRepoTest tests, however the underlaying cause is that the OperationRepo sometimes processes operations out of order.
Scope
Only effects operation repo logic.
Testing
Unit testing
No new tests added, existing coverage already.
Manual testing
Tested on an Android 14 and Android 6 emulator, ensured a new User and Subscription gets created.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is