Skip to content

Conversation

david-driscoll
Copy link
Member

https://github.com/actions/setup-dotnet allows side-by-side installs now

@github-actions github-actions bot added this to the v0.18.0 milestone Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #374 into master will increase coverage by 5.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   70.27%   75.38%   +5.10%     
==========================================
  Files         443      443              
  Lines       12764    12764              
  Branches     1177     1162      -15     
==========================================
+ Hits         8970     9622     +652     
+ Misses       3383     3142     -241     
+ Partials      411        0     -411     
Impacted Files Coverage Δ
src/JsonRpc.Generators/Helpers.cs 56.67% <0.00%> (+0.77%) ⬆️
src/Client/LanguageClientOptionsExtensions.cs 42.70% <0.00%> (+1.04%) ⬆️
...t/DebugAdapterClientServiceCollectionExtensions.cs 96.59% <0.00%> (+1.13%) ⬆️
...r/DebugAdapterServerServiceCollectionExtensions.cs 95.89% <0.00%> (+1.36%) ⬆️
...rotocol/Client/WorkDone/WorkDoneProxyExtensions.cs 13.63% <0.00%> (+1.51%) ⬆️
...rc/Client/LanguageClientWorkspaceFoldersManager.cs 94.73% <0.00%> (+1.75%) ⬆️
...erver/LanguageServerServiceCollectionExtensions.cs 97.19% <0.00%> (+1.86%) ⬆️
src/JsonRpc.Testing/Settler.cs 100.00% <0.00%> (+2.00%) ⬆️
...t/TestingUtils/AutoNSubstitute/DryIocExtensions.cs 100.00% <0.00%> (+2.04%) ⬆️
...lient/LanguageClientServiceCollectionExtensions.cs 96.90% <0.00%> (+2.06%) ⬆️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e637b3f...658ef4f. Read the comment docs.

@david-driscoll david-driscoll added chore Just keeping things neat and tidy merge Shipit! labels Oct 1, 2020
@david-driscoll david-driscoll merged commit 105b991 into master Oct 1, 2020
@mergify mergify bot removed the merge Shipit! label Oct 1, 2020
@mergify mergify bot deleted the fix/dotnet-hack branch October 1, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Just keeping things neat and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant