LspRouter update, update Supports<>

[david-driscoll]

Two things:

• Updated the router to pick the proper ITextDocumentSyncHandler previously this would pick the first one, which was only right if the one you wanted was first. No other handlers would.
• ITextDocumentSyncHandler.GetTextDocumentAttributes can return null, previously this was assumed to be not null.
  • However one of your handlers should return a non null value or nothing will get routed.
• Added some tests around LspRequestRouter to ensure it's working as intended (I hope, 😱)
• Fixes Conversion of unsupported ClientCapabilities is incompatible with other LSP implementations. #35 using the hacky feeling ShouldSerializeX in Newtonsoft.Json. There is be a better way I'm sure, but these methods will be hidden from intellisense for consumers.

[david-driscoll]

@tintoy going to push this as 0.4.0, let me know if you run into any problems.

[tintoy]

Cheers! Will give it a go in an hour or so

[tintoy]

What's the expected behaviour for requests / notifications where multiple handlers for the same method are registered?

[tintoy]

Ah, needs a logger factory now; will add one.

[tintoy]

Yep! Works fine, cheers :)

[tintoy]

Oops, spoke too soon:

System.NullReferenceException: Object reference not set to an instance of an object.
   at OmniSharp.Extensions.LanguageServer.LanguageServer.HasHandler[T](DynamicCapability capability)
   at OmniSharp.Extensions.LanguageServer.LanguageServer.<OmniSharp-Extensions-JsonRpc-IRequestHandler<OmniSharp-Extensions-LanguageServer-Models-InitializeParams\,OmniSharp-Extensions-LanguageServer-Models-InitializeResult>-Handle>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Extensions.LanguageServer.LspRequestRouter.<RouteRequest>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Extensions.JsonRpc.InputHandler.<>c__DisplayClass17_0.<<HandleRequest>b__3>d.MoveNext()

As shown here:

https://github.com/tintoy/dotnet-language-client/blob/master/samples/SingleProcess/Program.cs#L173

[tintoy]

Looks like the overload of HasHandler<T> that takes DynamicCapability (class) instead of SupportsDynamicCapability<T> (struct) needs to do a null-check; IIRC, it's legal for those fields to be null.

[david-driscoll]

I didn't get to this last night... fixing shortly.