Skip to content

Conversation

david-driscoll
Copy link
Member

Fixes #252

@david-driscoll david-driscoll added the enhancement New feature or request label Aug 28, 2020
@github-actions github-actions bot added this to the v0.18.0 milestone Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #339 into master will decrease coverage by 0.12%.
The diff coverage is 71.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   75.30%   75.17%   -0.13%     
==========================================
  Files         427      428       +1     
  Lines       12434    12495      +61     
  Branches     1134     1146      +12     
==========================================
+ Hits         9363     9393      +30     
- Misses       3071     3102      +31     
Impacted Files Coverage Δ
test/TestingUtils/Attributes.cs 40.38% <40.38%> (ø)
src/Protocol/DocumentUri.Internal.cs 95.28% <100.00%> (+0.16%) ⬆️
src/Server/DefaultLanguageServerFacade.cs 78.78% <100.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383d6c2...8334a47. Read the comment docs.

@david-driscoll david-driscoll added the merge Shipit! label Aug 28, 2020
@david-driscoll david-driscoll removed the merge Shipit! label Aug 28, 2020
@david-driscoll david-driscoll added the merge Shipit! label Aug 28, 2020
@david-driscoll david-driscoll removed the merge Shipit! label Aug 28, 2020
@david-driscoll david-driscoll force-pushed the fix/document-uri-stringbuilder branch from 161d3f7 to 5093b02 Compare August 29, 2020 04:14
@david-driscoll david-driscoll merged commit c7716ce into master Aug 29, 2020
@mergify mergify bot deleted the fix/document-uri-stringbuilder branch August 29, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentUri should use string builder where appropraite
1 participant