[PowerPoint] Add binding-to-shapes snippet #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchesnut
reviewed
May 2, 2025
Member
davidchesnut
left a comment
davidchesnut
left a comment
There was a problem hiding this comment.
Looks good, a few suggestions.
| document | ||
| .getElementById("insert-image-and-create-binding") | ||
| .addEventListener("click", () => tryCatch(insertImageWithBinding)); | ||
| document.getElementById("replace-binding1").addEventListener("click", () => tryCatch(replaceImageinBinding1)); |
Member
There was a problem hiding this comment.
You can get rid of the 1..3 functions by using this syntax to pass the values instead:
document.getElementById("replace-binding1").addEventListener("click", () => tryCatch(() => {replaceBinding(1)}));
document.getElementById("replace-binding2").addEventListener("click", () => tryCatch(() => { replaceBinding(2) }));
document.getElementById("replace-binding3").addEventListener("click", () => tryCatch(() => { replaceBinding(3) }));| }); | ||
| } | ||
|
|
||
| function replaceImageinBinding1() { |
Member
There was a problem hiding this comment.
You can drop all 3 of these functions if you use the updated trycatch blocks above.
Co-authored-by: David Chesnut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.