MasterVault as ERC4626 #124
Closed
+132
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+56
to
+68
| function deposit(uint256 assets, address receiver) public virtual override returns (uint256 shares) { | ||
| if (subVault == address(0)) { | ||
| revert SubVaultIsNotSet(); | ||
| } | ||
| amountDeposited = IERC4626(subVault).deposit(amount, gateway); | ||
| emit Deposited(amount); | ||
|
|
||
| IERC20(underlyingAsset).safeTransferFrom(msg.sender, address(this), assets); | ||
| IERC20(underlyingAsset).safeIncreaseAllowance(subVault, assets); | ||
| IERC4626(subVault).deposit(assets, address(this)); | ||
| shares = convertToShares(assets); | ||
| netDeposits += assets; | ||
| _mint(receiver, shares); | ||
| emit Deposit(msg.sender, receiver, assets, shares); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Comment on lines
+77
to
+94
| function withdraw(uint256 assets, address receiver, address owner) public virtual override returns (uint256 shares) { | ||
| if (subVault == address(0)) { | ||
| revert SubVaultIsNotSet(); | ||
| } | ||
| uint256 shares = IERC4626(subVault).withdraw(amount, recipient, gateway); | ||
| emit Withdrawn(amount, recipient, shares); | ||
|
|
||
| shares = convertToShares(assets); | ||
|
|
||
| if (msg.sender != owner) { | ||
| _spendAllowance(owner, msg.sender, shares); | ||
| } | ||
|
|
||
| uint256 subVaultAssets = _calculateSubVaultWithdrawal(assets); | ||
| IERC4626(subVault).withdraw(subVaultAssets, address(this), address(this)); | ||
| _burn(owner, shares); | ||
| netDeposits -= assets; | ||
| IERC20(underlyingAsset).safeTransfer(receiver, assets); | ||
| emit Withdraw(msg.sender, receiver, owner, assets, shares); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
waelsy123
force-pushed
the
wa/ybb-master-vault
branch
from
802b031 to
fdf4733
Compare
godzillaba
force-pushed
the
wa/ybb-master-vault
branch
from
0cb6a58 to
fdf4733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.