YBB review #121
Merged
YBB review #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or MVF, add comments/todos/questions
waelsy123
reviewed
Sep 19, 2025
|
|
||
| address public override inbox; | ||
| address public masterVault; | ||
| address public masterVaultFactory; |
There was a problem hiding this comment.
what is the reason to have masterVaultFactory here instead of masterVault? isn't every L1*Gateway deals with only one master vault?
There was a problem hiding this comment.
the gateways handle multiple tokens, so they'll need to deal with multiple vaults
waelsy123
reviewed
Sep 19, 2025
| bytes memory bytecode = abi.encodePacked( | ||
| type(MasterVault).creationCode, | ||
| abi.encode(token, gateway, gateway) | ||
| abi.encode(token) |
There was a problem hiding this comment.
the constructor expect these args:
constructor(address _token, address _gateway, address _owner) Ownable() {
There was a problem hiding this comment.
@godzillaba do you agree with me on having the token address as part of masterVault storage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.