Add verification of contracts #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TucksonDev
commented
Aug 21, 2025
| let verificationQueue: VerificationRequest[] = [] | ||
|
|
||
| // Helper function to encode constructor arguments based on their types | ||
| function abiEncodeConstructorArguments(args: any[]): string { |
There was a problem hiding this comment.
Crafted this function to avoid having to pass the types of arguments for verification
TucksonDev
commented
Aug 21, 2025
| /* | ||
| if (verify) { | ||
| await verifyContract( | ||
| queueContractForVerification( |
There was a problem hiding this comment.
Verification of contracts is queued to separate it from deployment (mainly for having cleaner logs)
TucksonDev
commented
Aug 21, 2025
| L1GatewayRouter: | ||
| 'contracts/tokenbridge/ethereum/gateway/L1GatewayRouter.sol:L1GatewayRouter', | ||
| standardGatewayTemplate: | ||
| L1ERC20Gateway: |
There was a problem hiding this comment.
Changed the keys of this object to use directly the name of the contract instead of custom keys (since these are not used anymore in the calling function)
TucksonDev
commented
Aug 21, 2025
| useCreate2 | ||
| ) | ||
| await initializeContract(parentGatewayRouterTemplate, [ | ||
| await initializeContract('L1GatewayRouter', parentGatewayRouterTemplate, [ |
There was a problem hiding this comment.
Passing the name of the contract for logging mainly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #114 , adding the verification of the deployed contracts