core: Add multigas to EndTxHook and safeDecrement #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaRogachev
changed the title
4 tasks
gligneul
requested changes
Nov 21, 2025
| res.gas[kind] = v | ||
| } | ||
|
|
||
| if t, c := bits.Sub64(res.total, gas, 0); c != 0 { |
Contributor
There was a problem hiding this comment.
There is a bug here when you have multiple constraints and it underflows a single constraint.
MultiGas(Computation=10, StorageAccess=10, total=20) - MultiGas(Computation=20, total=20)
The implementation will return
MultiGas(Computation=0, StorageAccess=10, total=0)
The correct value is
MultiGas(Computation=0, StorageAccess=10, total=10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of NIT-4069
Nitro PR: OffchainLabs/nitro#4012
Changes:
EndTxHooksafeDecrementfor MultiGas (used in nitro code)