Close issue #51. Correct javadoc for Encode class. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close issue #51
This is the result of my testing some of the Encode static methods from a new Clojure wrapper library that I plan to soon be releasing. There are no actual code changes here.
Note that places like
forCssString(String)where it said that '(' and ')' were encoded, but they are not. There are also other places (e.g.,forUriComponent(String)) where it said a character was NOT encoded (e.g., '@' for the case just mentioned), but it was. I will leave it up to you if you wish to adjust any of your JUnit tests.Lastly, there were a few minor additions that I consider as improvements, especially to novices, such as a reference to the Cross-Site Scripting Prevention Cheat Sheet, adding cross-reference links in a few places, etc.