Android autostart #418
Merged
Android autostart #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpt to load the plugin by plugin name when it can't find the plugin file. This works with a change to libfunctionality to attempt loading plugin entry points from the pre-loaded symbols list.
Member
|
I think this looks good, as long as the various consumers of the Android port (Unity CI? others?) are sure to verify that they're including the sufficient dependency libraries (basically that clientkit implies bring the whole family). |
|
|
||
| // @todo use a thread-safe lazy-initialized singleton pattern | ||
| #if defined(OSVR_ANDROID) | ||
| static osvr::server::ServerPtr gServer; |
Member
There was a problem hiding this comment.
Did you want to do anything about this before merge, or will you file an issue, or is it not expected to be a big deal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the auto-start API for Android. It requires linking osvrClientKit to osvrServer, but this is only done for the Android platform.
Requires this libfunctionality PR to be merged: OSVR/libfunctionality#15