Can't build meta-chromium with python3.13

[jcalvinowens]

This happens because the disttools module is no more, see https://peps.python.org/pep-0632/

DEBUG: Executing python function do_check_llvm_version
ERROR: Error executing a python function in exec_func_python() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_func_python() autogenerated', lineno: 2, function: <module>
     0001:
 *** 0002:do_check_llvm_version(d)
     0003:
File: '/home/calvinow/git/meta-roosevelt/build/../meta-browser/meta-chromium/recipes-browser/chromium/chromium-gn.inc', lineno: 400, function: do_check_llvm_version
     0396:# Check the LLVMVERSION defined in the meta-clang layer. Given Chromium is
     0397:# developed using new C++ features, the LLVMVERSION has to be >= 14. Otherwise,
     0398:# it is not guaranteed that Chromium will compile.
     0399:python do_check_llvm_version () {
 *** 0400:  from distutils.version import LooseVersion
     0401:
     0402:  min_llvm_version = "14.0.0"
     0403:  llvm_version = d.getVar('LLVMVERSION', False)
     0404:  if not llvm_version:
Exception: ModuleNotFoundError: No module named 'distutils'

DEBUG: Python function do_check_llvm_version finished

I haven't had time to spin a PR to fix this yet, but will soon if somebody doesn't beat me to it.

[kraj]

We can use python3-packaging to provide this. Try something like below and see if it works.

diff --git a/meta-chromium/recipes-browser/chromium/chromium-gn.inc b/meta-chromium/recipes-browser/chromium/chromium-gn.inc
index 98716ad..ac397cc 100644
--- a/meta-chromium/recipes-browser/chromium/chromium-gn.inc
+++ b/meta-chromium/recipes-browser/chromium/chromium-gn.inc
@@ -397,7 +397,7 @@ addtask create_v8_qemu_wrapper after do_patch before do_configure
 # developed using new C++ features, the LLVMVERSION has to be >= 14. Otherwise,
 # it is not guaranteed that Chromium will compile.
 python do_check_llvm_version () {
-  from distutils.version import LooseVersion
+  from packaging.version import parse

   min_llvm_version = "14.0.0"
   llvm_version = d.getVar('LLVMVERSION', False)
@@ -406,7 +406,7 @@ python do_check_llvm_version () {
             "successfully if the LLVM version is below %s." % min_llvm_version)
     return

-  if LooseVersion(llvm_version) < LooseVersion(min_llvm_version):
+  if parse(llvm_version) < parse(min_llvm_version):
     bb.fatal("Your LLVMVERSION (%s) is lower than the minimum required "
              "LLVMVERSION (%s). If you are using dunfell, make sure you "
              "use dunfell-clang14 branch." % (llvm_version, min_llvm_version))

[jcalvinowens]

Sorry for dropping this, it's since been fixed.

[chris-laplante]

Sorry for dropping this, it's since been fixed.

I just hit this, and I don't see a fix. Should I submit a PR with Khem's change from above?

[jcalvinowens]

Heh, it works for me now and I assumed it'd been fixed... but it turns out my distro started shipping disttools separately with 3.13 after it broke a bunch of other things. So this definitely ought to still be fixed, if you want to do the PR go for it.