Merge pull request #187 from OS2Forms/feature/avoid-double-save-on-name-and-address-protected-submission

#186: Avoid multiple saves when handling name and address protection

Author: rimi-itk

CHANGELOG.md

@@ -11,6 +11,7 @@ before starting to add changes. Use example [placed in the end of the page](#exa
 
 ## [Unreleased]
 
+- Avoid double-saving submissions when handling name and address protection.
 - [PR-191](https://github.com/OS2Forms/os2forms/pull/191)
   Re-throws exception to ensure failed status during Maestro notification job.
 - [PR-202](https://github.com/OS2Forms/os2forms/pull/202)

modules/os2forms_nemid/os2forms_nemid.module

@@ -469,5 +469,4 @@ function os2forms_nemid_submission_set_address_protected(array $form, FormStateI
   $data = $webformSubmission->getData();
   $data['os2forms_nemid_elements_nemid_address_protected'] = TRUE;
   $webformSubmission->setData($data);
-  $webformSubmission->save();
 }

modules/os2forms_nemid/src/Plugin/WebformElement/NemidAddress.php

@@ -47,9 +47,19 @@ public function alterForm(array &$element, array &$form, FormStateInterface $for
     // Only manipulate element on submission create form.
     if (!$webformSubmission->isCompleted()) {
       if ($cprLookupResult && $cprLookupResult->isNameAddressProtected()) {
-        $element['#info_message'] = 'adresse beskyttelse';
         NestedArray::setValue($form['elements'], $element['#webform_parents'], $element);
-        $form['actions']['submit']['#submit'][] = 'os2forms_nemid_submission_set_address_protected';
+
+        // It is important the 'os2forms_nemid_submission_set_address_protected'
+        // submit action is executed before the 'save' action. Otherwise,
+        // submissions are both created and completed, resulting in unexpected
+        // behavior, e.g. handlers being run twice.
+        if (isset($form['actions']['submit']['#submit']) && is_array($form['actions']['submit']['#submit'])) {
+          array_unshift($form['actions']['submit']['#submit'], 'os2forms_nemid_submission_set_address_protected');
+        }
+        else {
+          $form['actions']['submit']['#submit'][] = 'os2forms_nemid_submission_set_address_protected';
+        }
+
       }
     }
     else {