Merge pull request #199 from itk-dev/feature/190-maestro-notification-exception-handling

#190: Rethrow exception to ensure failed job status in Maestro notifi…

Author: rimi-itk

CHANGELOG.md

@@ -11,6 +11,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa
 
 ## [Unreleased]
 
+- [PR-191](https://github.com/OS2Forms/os2forms/pull/191)
+  Re-throws exception to ensure failed status during Maestro notification job.
 - [PR-202](https://github.com/OS2Forms/os2forms/pull/202)
   - Removed non-digits from recipient id in Maestro digital post notifications.
 - [PR-189](https://github.com/OS2Forms/os2forms/pull/189)

modules/os2forms_forloeb/src/MaestroHelper.php

@@ -205,7 +205,14 @@ public function processJob(Job $job): JobResult {
 
     $submission = $this->webformSubmissionStorage->load($submissionID);
 
-    $this->sendNotification($notificationType, $submission, $templateTask, $maestroQueueID);
+    try {
+      $this->sendNotification($notificationType, $submission, $templateTask, $maestroQueueID);
+    }
+    catch (\Exception $e) {
+      // Logging is done by the sendNotification method.
+      // The job should be considered failed.
+      return JobResult::failure($e->getMessage());
+    }
 
     return JobResult::success();
   }
@@ -261,12 +268,15 @@ private function sendNotification(
       }
     }
     catch (\Exception $exception) {
+      // Log with context and rethrow exception.
       $this->error('Error sending notification: @message', $context + [
         '@message' => $exception->getMessage(),
         'handler_id' => 'os2forms_forloeb',
         'operation' => 'notification failed',
         'exception' => $exception,
       ]);
+
+      throw $exception;
     }
   }