[18.0][IMP] web_theme_classic Add ability to toggle theme

[ljmnoonan]

Now you can either enable by user with Classic Theme Persistent setting, or toggle it on and off like dark mode. It uses a cookie to remember your preference between reloads.

Screenshots

Toggle Hidden because Classic Theme Persistent turned on

[OCA-git-bot]

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

[ljmnoonan]

Closes #3234

[legalsylvain]

Feature looks disabled by défaut. Or did i missed something ?

[ljmnoonan]

@legalsylvain yes, I left the persistent option disabled by default so that the toggle on the user menu would be visible and individual users can make a choice whether to turn it on or not, and what mode to use.
I can change it though if you think it makes more sense to enable persistent mode for all users at install by default

[legalsylvain]

@legalsylvain yes, I left the persistent option disabled by default so that the toggle on the user menu would be visible and individual users can make a choice whether to turn it on or not, and what mode to use.

Well, If someone install this module, he hopes that the feature will be enabled by default. Otherwise, it forces each user to enable it manually. So, yes, please put the value enabled by default. If user want to disable it, he can.
Don't you think ?

[ljmnoonan]

@legalsylvain Yes, I see what you mean. I will change it

[ljmnoonan]

@legalsylvain All set!

[legalsylvain]

thanks !

[ljmnoonan]

While working in web_dark_mode, I discovered that res_users_settings.py is already loaded into the user.settings object client side, so we can avoid an unnecessary orm call by using it. This means that persistent_classic_theme is just a related field in res_users.

I also updated the tests to HttpCase, which makes a lot more sense in this context

[legalsylvain]

While working in web_dark_mode, I discovered that res_users_settings.py is already loaded into the user.settings object client side

thanks. good to know.

[ljmnoonan]

@jappi00 if you get some time, would you mind reviewing this PR?

[jappi00]

@ljmnoonan functional test looks good. Will look into the code now.

[jappi00]

Looks good. Two little nitpicks 💃

[jappi00]

I think you should write "Uncheck" since you enabled the theme by default if the conversation in the pr is right?

[jappi00]

ofc: nitpick

[ljmnoonan]

I think it should stay "check" as writing "uncheck" would necessitate inverting the whole sentence. It's kind of odd describing a feature by what it doesn't do when it is turned off. The next line describes behavior when unchecked too.

[jappi00]

nitpick: maybe add help for the note from the configure.md, something like: "When switching the theme all users need to reload the page to have a effect."

[ljmnoonan]

There is already a pretty verbose tooltip defined in res_users.py, although it does not mention the need to reload. I'm hesitant to add this though as pressing "Save" from the view_users_form_simple_modif modal actually triggers a reload, so it is only in the context of view_users_form that this is relevant. Also, I think it is something that should be rather obvious to any user savvy enough to enable debug mode, which is necessary to see this option in the context of view_users_form in the first place.
If @legalsylvain thinks it is necessary too, I will add it

[jappi00]

@ljmnoonan oh, clear!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[ljmnoonan]

@jappi00 Thank you for the review!