[17.0][FIX] web_responsive: prevent error in tests when accessing an undefined variable #3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned variable For an unknown reason, when running the tests, the session does not have all variables filled, so apps_menu is undefined. This causes an error in tours of other modules: "Cannot read properties of undefined (reading 'theme')". The curious thing is that if you run the tests of this module alone, they pass. But when running tests together with another module, tests from the other module fail. For example, when running tests with the voip_oca module.
Contributor
CarlosRoca13
approved these changes
Aug 6, 2025
Contributor
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 4a4c0d3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reason, when running the tests, the
sessiondoes not have all variables filled, soapps_menuis undefined. This causes an error in tours of other modules:Cannot read properties of undefined (reading 'theme').The curious thing is that if you run the tests of this module alone, they pass.
But when running tests together with another module, or starting the test manually from the browser, tests from the other module fail.
For example, when running tests with the
voip_ocamodule.After this commit, the tests pass correctly:
@Tecnativa @pedrobaeza @CarlosRoca13 could you please review this?