Skip to content

[FIX] base_kanban_stage: fix wrong field referenced in base_kanban_abstract_view_kanban #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lasley merged 1 commit into from
Sep 5, 2017
Merged

[FIX] base_kanban_stage: fix wrong field referenced in base_kanban_abstract_view_kanban #949

lasley merged 1 commit into from
Sep 5, 2017

Conversation

@tafaRU
Copy link
Member

@tafaRU tafaRU commented Aug 24, 2017 •
edited
Loading

No description provided.

@tafaRU tafaRU force-pushed the 10.0-base_kanban_stage-fix branch from 8eba23b to cec554f Compare August 24, 2017 21:04
@tafaRU tafaRU mentioned this pull request Aug 25, 2017
Closed
@dreispt
Copy link
Member

dreispt commented Aug 25, 2017

I disagree 👎:
The user_id is a special field that has special treatment is some places, such as the mail module.
It represents the responsible user, and that is a key concept for the kanban workflow.

@tafaRU
Copy link
Member Author

tafaRU commented Aug 25, 2017 •
edited
Loading

@dreispt, ok, however it's needed to change https://github.com/OCA/server-tools/blob/10.0/base_kanban_stage/views/base_kanban_abstract.xml#L53 and to modify slightly docstring at https://github.com/OCA/server-tools/blob/10.0/base_kanban_stage/models/base_kanban_abstract.py#L11

Are you ok with this proposal?

@lasley
Copy link
Contributor

lasley commented Aug 25, 2017

TIL about the user_id special treatment. I wish there was some sort of documentation to these special fields.

@tafaRU - yeah I think the suggestion of modifying the view & updating the doc string is the best way to go then. Maybe even a note about the special treatment so someone can get a random TIL if they're in the code.

@dreispt
Copy link
Member

dreispt commented Aug 26, 2017

If I understood correctly, the current version references an unexisting field kanban_user_id.
Yes, it should be fixed to user_id and a mention added to the docstring.

@dreispt
Copy link
Member

dreispt commented Aug 26, 2017

@lasley Have a look at mail.thread searching for user_id.

@tafaRU
[FIX] base_kanban_stage: fix wrong field referenced in base_kanban_ab…
5721fa5 
…stract_view_kanban; user_id instead of kanban_user_id
@tafaRU tafaRU force-pushed the 10.0-base_kanban_stage-fix branch from cec554f to 5721fa5 Compare August 28, 2017 16:34
@tafaRU tafaRU changed the title [FIX] base_kanban_stage: kanban_user_id instead of user_id [FIX] base_kanban_stage: fix wrong field referenced in base_kanban_ab… …stract_view_kanban Aug 28, 2017
@tafaRU tafaRU changed the title [FIX] base_kanban_stage: fix wrong field referenced in base_kanban_ab… …stract_view_kanban [FIX] base_kanban_stage: fix wrong field referenced in base_kanban_abstract_view_kanban Aug 28, 2017
@tafaRU
Copy link
Member Author

tafaRU commented Aug 28, 2017 •
edited
Loading

@dreispt, @lasley, done.
I'll also modify the other PR, on 9.0 branch, once you'll have approved this.

Thank you in advance.

lasley
lasley approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @tafaRU

@tafaRU tafaRU mentioned this pull request Aug 29, 2017
Merged
@tafaRU
Copy link
Member Author

tafaRU commented Aug 29, 2017

Just made #954

@tafaRU
Copy link
Member Author

tafaRU commented Sep 5, 2017

@dreispt, could you please review?

@tafaRU tafaRU mentioned this pull request Sep 5, 2017
Closed
@lasley lasley merged commit 4d63c9e into OCA:10.0 Sep 5, 2017
tafaRU added a commit to tafaRU/server-tools that referenced this pull request Sep 6, 2017
@tafaRU
[FIX] base_kanban_stage: following on OCA#949
1754bd0
@tafaRU tafaRU mentioned this pull request Sep 6, 2017
Merged
tafaRU added a commit to tafaRU/server-tools that referenced this pull request Sep 6, 2017
@tafaRU
[FIX] base_kanban_stage: following on OCA#949
8c5c033
tafaRU added a commit to tafaRU/server-tools that referenced this pull request Sep 6, 2017
@tafaRU
[FIX] base_kanban_stage: following on OCA#949
d2ce8c1
@tafaRU tafaRU mentioned this pull request Sep 6, 2017
Merged
tafaRU added a commit to tafaRU/server-tools that referenced this pull request Sep 6, 2017
@tafaRU
[FIX] base_kanban_stage: following on OCA#949
dbb0f0c
lasley added a commit that referenced this pull request Sep 6, 2017
@lasley
Merge pull request #967 from tafaRU/10.0-base_kanban_stage-fix2
fc28c0f 
[FIX] base_kanban_stage: following on #949
AaronHForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Sep 17, 2019
@tafaRU @AaronHForgeFlow
[FIX] base_kanban_stage: following on OCA#949
26d6c60
MiquelRForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Sep 27, 2019
@tafaRU @MiquelRForgeFlow
[FIX] base_kanban_stage: following on OCA#949
16795c3
Tardo pushed a commit to Tecnativa/server-tools that referenced this pull request Dec 5, 2019
@tafaRU @Tardo
[FIX] base_kanban_stage: following on OCA#949
4b4ccff
mileo pushed a commit to kmee/server-tools that referenced this pull request Mar 31, 2020
@tafaRU @mileo
[FIX] base_kanban_stage: following on OCA#949
09e320d
mileo pushed a commit to kmee/server-tools that referenced this pull request Jun 24, 2020
@tafaRU @mileo
[FIX] base_kanban_stage: following on OCA#949
3ed15e9
fshah-initos pushed a commit to initOS/server-tools that referenced this pull request Dec 11, 2020
@tafaRU @fshah-initos
[FIX] base_kanban_stage: following on OCA#949
82aed9f
fshah-initos pushed a commit to initOS/server-tools that referenced this pull request Mar 4, 2021
@tafaRU @fshah-initos
[FIX] base_kanban_stage: following on OCA#949
9fb8104
hkapatel-initos pushed a commit to initOS/server-tools that referenced this pull request Jun 24, 2021
@tafaRU @hkapatel-initos
[FIX] base_kanban_stage: following on OCA#949
33c2bff
hkapatel-initos pushed a commit to initOS/server-tools that referenced this pull request Jul 2, 2021
@tafaRU @hkapatel-initos
[FIX] base_kanban_stage: following on OCA#949
96b1435
MiquelRForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Aug 4, 2021
@tafaRU @MiquelRForgeFlow
[FIX] base_kanban_stage: following on OCA#949
fd3f71a
mtelahun pushed a commit to mtelahun/server-tools that referenced this pull request Sep 5, 2022
@tafaRU @mtelahun
[FIX] base_kanban_stage: following on OCA#949
091b88a
AaronHForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Dec 2, 2022
@tafaRU @AaronHForgeFlow
[FIX] base_kanban_stage: following on OCA#949
5bddccf
odooNextev pushed a commit to odooNextev/server-tools that referenced this pull request May 30, 2023
@tafaRU @matteonext
[FIX] base_kanban_stage: following on OCA#949
f8c17ae
AaronHForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Aug 4, 2023
@tafaRU @AaronHForgeFlow
[FIX] base_kanban_stage: following on OCA#949
9c96750
AaronHForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Oct 31, 2023
@tafaRU @AaronHForgeFlow
[FIX] base_kanban_stage: following on OCA#949
4febfb8
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#949 from OCA/15.0
8efd29f 
Syncing from upstream OCA/server-tools (15.0)
mileo pushed a commit to kmee/server-tools that referenced this pull request May 25, 2025
@tafaRU @mileo
[FIX] base_kanban_stage: following on OCA#949
c281ac6
AaronHForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request May 26, 2025
@tafaRU @AaronHForgeFlow
[FIX] base_kanban_stage: following on OCA#949
db45c17
AaronHForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Aug 13, 2025
@tafaRU @AaronHForgeFlow
[FIX] base_kanban_stage: following on OCA#949
0cb10a5
JasminSForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Dec 22, 2025
@tafaRU @JasminSForgeFlow
[FIX] base_kanban_stage: following on OCA#949
72d0563
JasminSForgeFlow pushed a commit to ForgeFlow/server-tools that referenced this pull request Dec 22, 2025
@tafaRU @JasminSForgeFlow
[FIX] base_kanban_stage: following on OCA#949
c88fe05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lasley lasley lasley approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tafaRU @dreispt @lasley @MiquelRForgeFlow