Skip to content

Conversation

@hbrunn
Copy link
Member

@hbrunn hbrunn commented May 18, 2016

No description provided.

@hbrunn hbrunn added this to the 8.0 milestone May 18, 2016
@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage remained the same at 57.265% when pulling ce12cab on hbrunn:8.0-base_suspend_security-mute_logger into aae74f0 on OCA:8.0.

@pedrobaeza
Copy link
Member

Isn't better to inhibit the functionality when tests are enabled and you're testing other modules?

@hbrunn
Copy link
Member Author

hbrunn commented May 18, 2016

yes, but we have no influence on that: https://github.com/OCA/OCB/blob/8.0/openerp/addons/base/ir/ir_model.py#L767

@pedrobaeza
Copy link
Member

OK, I see. Then 👍

@moylop260
Copy link
Contributor

👍

@pedrobaeza pedrobaeza merged commit b717070 into OCA:8.0 Aug 5, 2016
@gurneyalex
Copy link
Member

@hbrunn @pedrobaeza this merge broke the 8.0 build.

@pedrobaeza
Copy link
Member

It was green in its moment, so I don't know what is happening. Do you have any clue?

@gurneyalex
Copy link
Member

I don't know, I just noticed the travis builds turned red on the build of the merge. Can be unrelated to this PR and related to #505 (database_cleanup breaking the build on 9.0), since the errors seem to be related to that module.

@gurneyalex
Copy link
Member

see also #507

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants