[17.0][MIG] module_auto_update

[fkantelberg]

I had to adjust some tests because:

• Odoo core removed the methods _patch_method and _revert_method
• There was no i18n/en.po in general

[pedrobaeza]

/ocabot migration module_auto_update

[thomaspaulb]

@fkantelberg Could you retrigger the runboat with a rebase?

[thomaspaulb]

@fkantelberg Looks like tests are failing in conjunction with database_cleanup_test

[fkantelberg]

@thomaspaulb True and I wonder why. I suspect that the tests of database_cleanup aren't cleaning up the database afterwards. I do believe that the module_auto_update works just fine. Maybe we have to think about a tearDown function in database_cleanup to remove the test data. Why do you think?

[thomaspaulb]

@fkantelberg After some investigation, found that database_cleanup tests are doing a commit

And I think in previous versions this was noted also and solved by running tests in isolation or setting it as a rebel module. Maybe we can try the same here on 17.0?

[fkantelberg]

Sure lets try the rebel one :)

[thomaspaulb]

Cool, will you cherry pick it as part of this PR?

[fkantelberg]

Seems to work. Not sure if I would rename the tests now to make it more descriptive.

[thomaspaulb]

Renaming which tests in which way?

[fkantelberg]

The tests are currently named:

• tests / test with Odoo
• tests /test with OCB
• tests / test with Odoo
• tests /test with OCB

The cherry pick duplicated the existing tests BUT the first to only test database_cleanup and the other 2 all other non-rebel modules. Not really descriptive but I could live with it.

[thomaspaulb]

Ahhhh yes. Well if they can be renamed, I would name the second one "Rebel tests with Odoo", it even sounds cool. But I wouldn't really know where to put it. If you do, and it's easy, then why not.

[fkantelberg]

It's defined in .github/worksflows/test.yml. I renamed the one which is only testing database_cleanup Rebel test ... because the cherry picked defined that modul as rebel :)

Thanks for the support.

[thomaspaulb]

@fkantelberg I don't see the addon hash tests running here in 17.0 either, so maybe this needs a cherry pick of #2847

[fkantelberg]

I cherry picked the interesting parts of it and I see the tests now in the logs. Seems like Odoo runs tests differently than I do locally.

[thomaspaulb]

What exactly did you cherry-pick though? I see the changes in the test file, but also changes in Contributors and other readme files

[fkantelberg]

cherry picked your linked commit. pre-commit did the rest but I squashed the commits.

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2763-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 48bf5d8. Thanks a lot for contributing to OCA. ❤️