[17.0][IMP] auth_oauth_autologin: Move all auto login logic to the backend #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved all auto login implementation to the backend * OZ-357: Removed repeat check for auth error * OZ-357: Refactored autologin code * Added tests for autologin feature * Cleaned up the tests for autologin feature * Fixed manifest file formatting * Added missing @http.route * Fixed broken tests after adding @http.route * Added small refactoring of the controller code
Contributor
|
Hi @sbidoul, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Member
|
See #717 (comment) for why this won't work in 17. In 18 it should be ok to make this a backend redirect again |
Contributor
Author
|
We have been using this feature for a while and we have not experienced that issue but I will test and verify. |
github-actions
bot
removed
the
stale
sbidoul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation of the oauth auto login feature that is handled by both front and back end logic, there is an annoying issue where the user temporarily sees the Odoo login page before they get redirected to the IDP's login page.
This PR modifies the oauth auto login addon so that the logic is implemented on the backend to resolve the issue.