[16.0][IMP] auth_saml: Allow admin/managers to edit User SAML information #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
PCatinean
reviewed
May 21, 2024
| access_auth_res_users_saml,auth_res_users_saml,model_res_users_saml,base.group_system,1,1,1,1 | ||
| access_auth_res_users_saml,auth_res_users_saml,model_res_users_saml,base.group_erp_manager,1,1,1,1 | ||
| access_auth_saml_attribute_mapping,auth_saml_attribute_mapping,model_auth_saml_attribute_mapping,base.group_system,1,1,1,1 | ||
| auth_saml_provider_erp_manager_access,auth_saml_provider_erp_manager_access,model_auth_saml_provider,base.group_erp_manager,1,0,0,0 |
There was a problem hiding this comment.
I think we might still need this given that res.users.saml has a many2one to auth.saml.provider and one needs to select the provider when making/editing an entry
aronabencherif
force-pushed
the
16.0-auth-saml-downgrade-res_user-access-right
branch
from
b281457 to
5641a1b
Compare
PCatinean
approved these changes
May 21, 2024
bizzappdev
approved these changes
May 28, 2024
Contributor
Author
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
May 28, 2024
Contributor
|
@vincent-hatakeyama your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-652-by-vincent-hatakeyama-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
anoomk
pushed a commit
to ursais/server-auth
that referenced
this pull request
Jun 7, 2024
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
Updated the signin method to reflect changes in similar method signin from auth_oauth. Without the changes, the ORM crashes with psycopg2.errors.InvalidSavepointSpecification when trying to signin. Fixes OCA#664
As user in that group can already edit users, so it make sense to allow them to see and edit that information rather than restrict it to admin/system.
vincent-hatakeyama
force-pushed
the
16.0-auth-saml-downgrade-res_user-access-right
branch
from
5641a1b to
06b66a9
Compare
Contributor
Author
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at affe350. Thanks a lot for contributing to OCA. ❤️ |
alexis-via
pushed a commit
to akretion/server-auth
that referenced
this pull request
Nov 21, 2024
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
amh-mw
pushed a commit
to amh-mw/oca-server-auth
that referenced
this pull request
Jan 7, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-server-auth
that referenced
this pull request
Jan 18, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
IsabelAForgeFlow
pushed a commit
to ForgeFlow/server-auth
that referenced
this pull request
Mar 10, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
IsabelAForgeFlow
pushed a commit
to ForgeFlow/server-auth
that referenced
this pull request
Mar 10, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
amh-mw
pushed a commit
to amh-mw/oca-server-auth
that referenced
this pull request
Mar 22, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
Cl0ut1eR
pushed a commit
to Cl0ut1eR/server-auth
that referenced
this pull request
Apr 3, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
rjpathan
pushed a commit
to linserv/server-auth
that referenced
this pull request
May 12, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
bizzappdev
pushed a commit
to BizzAppDev-Systems/server-auth
that referenced
this pull request
Oct 17, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
bizzappdev
pushed a commit
to BizzAppDev-Systems/server-auth
that referenced
this pull request
Oct 27, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
bizzappdev
pushed a commit
to BizzAppDev-Systems/server-auth
that referenced
this pull request
Oct 27, 2025
* Add current time as password_write_date for admin user in demo, disabling the reset prompt - fixes OCA#652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As user in that group can already edit users, so it make sense to allow them to see and edit that information rather than restrict it to admin/system.