Skip to content

Conversation

@PicchiSeba
Copy link
Contributor

Move endpoint matching into its own method to allow other modules to override it

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you for the proposal @PicchiSeba

get_uid , get_app and get_endpoint no more receive a root path. They receive a path...

@PicchiSeba
Copy link
Contributor Author

PicchiSeba commented May 14, 2025

Hi @lmignon thank you for your review.

Do you want me to just change the names to path or to do something else?

EDIT: nvm, I just saw you other comment

@PicchiSeba PicchiSeba force-pushed the 16.0-get-endpoint-common-method branch from 018f44d to b44eefb Compare May 14, 2025 10:30
@PicchiSeba PicchiSeba force-pushed the 16.0-get-endpoint-common-method branch from b44eefb to 2e31e7f Compare May 15, 2025 07:18
@lmignon
Copy link
Contributor

lmignon commented May 15, 2025

closing since it will be merged with #515

@lmignon lmignon closed this May 15, 2025
@PicchiSeba PicchiSeba deleted the 16.0-get-endpoint-common-method branch May 15, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants