[16.0][FIX] fastapi: Ensure no default eventloop thread is created #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, an eventloop thread was created on each instanciation of the ASGIMiddleware class. We want to avoid this behavior to avoid the creation of zombie threads
lmignon
force-pushed
the
16.0-zombie-thread-next-lmi
branch
from
8d8d5a7 to
5505a6a
Compare
Contributor
Author
AnizR
reviewed
Mar 17, 2025
| # Since the the base class check if the given loop is | ||
| # None, we can pass False to avoid the initialization | ||
| # of the default event loop | ||
| super().__init__(app, wait_time, False) |
Contributor
There was a problem hiding this comment.
A bit hacky but I don't see any other option.
AnizR
reviewed
Mar 17, 2025
| def __init__( | ||
| self, | ||
| app: ASGIApp, | ||
| wait_time: float | None = None, |
Contributor
There was a problem hiding this comment.
Shouldn't we need to keep the parent signature?
loop: Optional[asyncio.AbstractEventLoop] = None,
Contributor
Author
There was a problem hiding this comment.
IMO no. This class is designed to be used in the specific context of the fastapi addon where we enforce the use of the pool of eventloop threads.
AnizR
approved these changes
Mar 18, 2025
Contributor
Author
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 90ae5a4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, an eventloop thread was created on each instanciation of the ASGIMiddleware class. We want to avoid this behavior to avoid the creation of zombie threads