[16.0][MIG] sql_export (from 15.0) #671

legalsylvain · 2022-10-26T12:00:15Z

split view in two files, according OCA guidelines;
add legalsylvain as maintainers
use abstract tree and form views
refactor : split demo data into two files, according OCA guidelines
replace obsolete base.menu_reporting_dashboard by spreadsheet_dashboard entries
update translation
prevent usage of export with parameters, that requires extra work

Note export with parameters doesn't work for the time being, due to the refactoring of fields_view_get in V16.
this should be reimplemented in another PR.

legalsylvain · 2022-10-26T14:35:07Z

/ocabot migration sql_export

OCA-git-bot · 2022-10-26T14:35:18Z

Sorry @legalsylvain you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

HviorForgeFlow · 2022-10-26T16:10:33Z

/ocabot migration sql_export

bealdav · 2022-11-23T09:27:38Z

@legalsylvain test-requirement.txt should alseo be removed here. Thanks a lot

Add rollback after executing query as a double security with blacklist terms add known issue in readme

[FIX] encoding with mogrify [FIX] hide placeholder

Currently translated at 100,0% (50 of 50 strings) Translation: server-tools-10.0/server-tools-10.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-10-0/server-tools-10-0-sql_export/de/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_export/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-sql_export/

Currently translated at 65.0% (39 of 60 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-sql_export/ca/

legalsylvain · 2022-11-23T15:23:04Z

Done @bealdav
Could you update your review ?

Thanks !

bealdav · 2022-11-23T16:42:48Z

Thanks a lot @legalsylvain for this huge improvement and cleaning.

2 bugs found testing it.

In draft state all is nice

Missing select string and other left string

Probably due to js psql syntax lib. A workaround could be to not strip the query. I think it's sufficient

bealdav · 2022-11-23T16:48:38Z

Syntax is not correct

But the module considers it's correct at the validation step.

Finally it fails at the execution step

legalsylvain · 2022-11-23T17:25:41Z

Hi @bealdav.

regarding the first bug, i faced to it. I think it's due to a problem in odoo js framework, when the field become readonly. Workaround found : reload the page, and all is OK. Is it OK for you ?
regarding the second bug : yes, it seems that it was explicitely disabled. the last commit fixes the problem. Could you test again ?

- split view in two files, according OCA guidelines; - add legalsylvain as maintainers - use abstract tree and form views - refactor : split demo data into two files, according OCA guidelines - replace obsolete base.menu_reporting_dashboard by spreadsheet_dashboard entries - update translation - prevent usage of export with parameters, that requires extra work - do not skip 'check execution' when confirming sql exports

bealdav

LGTM tested again on runboat.
OK now
Thanks a lot

florian-dacosta

LGTM and thanks for this port

OCA-git-bot · 2022-11-25T14:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

HviorForgeFlow · 2022-11-28T09:55:22Z

/ocabot merge nobump

OCA-git-bot · 2022-11-28T09:55:30Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-671-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2022-11-28T10:01:14Z

Congratulations, your PR was merged at badacc7. Thanks a lot for contributing to OCA. ❤️

legalsylvain force-pushed the 16.0-mig-sql_export branch from fa385b2 to 7291d72 Compare October 26, 2022 12:59

legalsylvain mentioned this pull request Oct 26, 2022

[16.0][MIG] sql_export_mail (from OCA/server-tools 14.0) #672

Merged

OCA-git-bot added this to the 16.0 milestone Oct 26, 2022

OCA-git-bot mentioned this pull request Oct 26, 2022

Migration to version 16.0 #653

Open

15 tasks

florian-dacosta and others added 22 commits November 23, 2022 16:21

Add sql export module (migration from v7)

5fabbb4

Add rollback after executing query as a double security with blacklist terms add known issue in readme

[IMP] add support of variables in queries

bf2ab7c

[FIX] encoding with mogrify [FIX] hide placeholder

[MIG] Migrate module from 8.0 to 9.0

21a9b84

[REF] create a new module sql_request_abstract

59bbdc9

Fix version

f9d1e60

[IMP]encode output file

a9d309e

[FIX] various improvement. Courtesy @dreispt review

52d71f9

OCA Transbot updated translations from Transifex

1834a15

[MIG][10.0]sql_export v10

dabf0ca

[FIX] mogrify doesn't allow dicts

555c6f5

[UPD] Update sql_export.pot

65d573a

Translated using Weblate (German)

62daa65

Currently translated at 100,0% (50 of 50 strings) Translation: server-tools-10.0/server-tools-10.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-10-0/server-tools-10-0-sql_export/de/

IMP Readme for Sql Export Module

7cdacf5

Update translation files

02b595f

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

PORT v12 sql_export

3f86fe0

FIX sql_export: test and misc

a52c021

[UPD] Update sql_export.pot

161fd19

[FIX] title level in readme fragments

7f0f94a

[UPD] README.rst

f5cc593

Update translation files

c475613

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_export/

IMP sql_export: render field as require when matching field def

15fe7ef

Fix uses of params in sql query

a03f438

oca-travis and others added 11 commits November 23, 2022 16:21

[UPD] Update sql_export.pot

94dcf86

sql_export 14.0.1.1.0

c6bfb45

Update translation files

466ea6f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-sql_export/

[UPD] Update sql_export.pot

10cf7d4

Update translation files

23c5db2

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-sql_export/

[IMP] sql_export: black, isort, prettier

eada404

[MIG] sql_export: Migration to 15.0

c79b330

[UPD] Update sql_export.pot

bbdc95e

[UPD] README.rst

63d5d12

Translated using Weblate (Catalan)

2acdeb9

Currently translated at 65.0% (39 of 60 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-sql_export Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-sql_export/ca/

[IMP] sql_export: black, isort, prettier

c8ad9aa

legalsylvain force-pushed the 16.0-mig-sql_export branch from 7291d72 to 2638d9e Compare November 23, 2022 15:22

legalsylvain force-pushed the 16.0-mig-sql_export branch from 6ef680d to a70ff1a Compare November 24, 2022 08:35

bealdav approved these changes Nov 25, 2022

View reviewed changes

florian-dacosta approved these changes Nov 25, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 25, 2022

OCA-git-bot added the bot is merging ⏳ label Nov 28, 2022

OCA-git-bot merged commit f57897d into OCA:16.0 Nov 28, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 28, 2022

Uh oh!

[16.0][MIG] sql_export (from 15.0) #671

[16.0][MIG] sql_export (from 15.0) #671

Uh oh!

Conversation

legalsylvain commented Oct 26, 2022

Uh oh!

legalsylvain commented Oct 26, 2022

Uh oh!

OCA-git-bot commented Oct 26, 2022

Uh oh!

HviorForgeFlow commented Oct 26, 2022

Uh oh!

bealdav commented Nov 23, 2022

Uh oh!

legalsylvain commented Nov 23, 2022

Uh oh!

bealdav commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bealdav commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain commented Nov 23, 2022

Uh oh!

bealdav left a comment

Choose a reason for hiding this comment

Uh oh!

florian-dacosta left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 25, 2022

Uh oh!

HviorForgeFlow commented Nov 28, 2022

Uh oh!

OCA-git-bot commented Nov 28, 2022

Uh oh!

OCA-git-bot commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

bealdav commented Nov 23, 2022 •

edited

Loading

bealdav commented Nov 23, 2022 •

edited

Loading