[16.0] [MIG] base_comment_template #664

AMhadhbi · 2022-10-18T13:11:27Z

No description provided.

Port modules base_comment_template and invoice_comment_template to V10

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/gl/ [ADD] icon.png

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/ja/

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt/

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_BR/

[IMP] Move comment_template_id from account_invoice_comment_template and make it company_dependant [IMP] base_comment_template: Add test

…d to the Invoicing tab [IMP] account_invoice_comment_template: rename partner field name from comment_template_id to invoice_comment_template_id [IMP] account_invoice_comment_template: Make partner field company_dependant and move domain definition of invoice fields from the view to the model [MOV] account_invoice_comment_template: comment_template_id to base_comment_template [IMP] account_invoice_comment_template: Translate templates when partner changes

[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_BR/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt/

Currently translated at 95.2% (20 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/hr/

Previous field declaration was incorrect due to a typo, leading to non applying the company dependent features. Now everything is correct and the migration scripts care of moving data properly.

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/de/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_PT/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/sk/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/

As the field was not properly converted to property at 2.0.0, the script fails to do its job when migrating from v11, so we need to adapt the scripts to this situation.

[UPD] Update base_comment_template.pot [UPD] README.rst

…ing.

…ords

base_comment_template 14.0.2.0.1

Currently translated at 100.0% (36 of 36 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/pt/

Currently translated at 100.0% (36 of 36 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/it/

[UPD] Update base_comment_template.pot [UPD] README.rst base_comment_template 14.0.3.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/

base_comment_template 14.0.3.0.1

TT35696

AMhadhbi · 2022-10-19T10:52:41Z

/ocabot migration base_comment_template

OCA-git-bot · 2022-10-19T10:53:05Z

Sorry @AMhadhbi you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza · 2022-10-19T11:46:56Z

/ocabot migration base_comment_template

marylla

I actually only do functional testing and this module is just the base module, but I checked in runboat that I can see the views:

tree view of comments in partner form view
menu for all comments here: settings > technical > reporting > comment templates

Of course, I could not create a comment template because we need account_comment_template (OCA/account-invoice-reporting#242) or sale_comment_template or a similiar extension.
I will test those after this module is merged. :)

Can someone do a code review too?

OCA-git-bot · 2022-10-25T08:17:07Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

marylla · 2022-10-25T08:23:59Z

@pedrobaeza Hi Pedro, can you merge this PR please?

pedrobaeza · 2022-10-25T09:08:40Z

/ocabot merge nobump

OCA-git-bot · 2022-10-25T09:08:53Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-664-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-10-25T09:13:41Z

Congratulations, your PR was merged at 92f5706. Thanks a lot for contributing to OCA. ❤️

Guewen Baconnier and others added 30 commits October 18, 2022 11:50

Rename base_condition_template to base_comment_template

20ac6e7

[MIG] base_comment_template to 9.0

d69e861

[MIG] base_comment_template, invoice_comment_template: Migration to 10.0

cef0aac

Port modules base_comment_template and invoice_comment_template to V10

[MIG] base_comment_template: Migration to 11.0

49a576f

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[MIG] base_comment_template: Migration to 12.0

f36cd66

[IMP] base_comment_template multi company rules

9bb954e

[IMP] Move comment_template_id from account_invoice_comment_template and make it company_dependant [IMP] base_comment_template: Add test

[FIX] base_comment_template: Make field truly company dependent

93db34a

Previous field declaration was incorrect due to a typo, leading to non applying the company dependent features. Now everything is correct and the migration scripts care of moving data properly.

[FIX] base_comment_template: Make field truly company dependent

b4b4b14

Previous field declaration was incorrect due to a typo, leading to non applying the company dependent features. Now everything is correct and the migration scripts care of moving data properly.

[MIG+FIX] base_comment_template: Fix migration scripts

a68ef0d

As the field was not properly converted to property at 2.0.0, the script fails to do its job when migrating from v11, so we need to adapt the scripts to this situation.

[IMP] base_comment_template: black, isort, prettier

6580035

[MIG] base_comment_template: Migration to 14.0 add unit test

9fb52a9

[UPD] Update base_comment_template.pot [UPD] README.rst

[MIG] [13.0] Migrate base_comment_template from account_invoic_report…

e2596e9

…ing.

[IMP] base_comment_template: Code refactorization

76db7b1

[IMP] base_comment_template: Improved sentences on fields

646f478

[IMP] base_comment_template: Add function to get_comment_template rec…

02f5d5f

…ords

[FIX] base_comment_template: Fix tests: test_company_general_template

a919336

[FIX] base_comment_template: Change domain in rule according to company

313f0eb

[IMP] base_comment_template: Refactor code and convert to Many2Many

3442072

victoralmau and others added 10 commits October 18, 2022 11:50

[FIX] base_comment_template: Delete res_partner.xml view (not used now)

f674d41

base_comment_template 14.0.2.0.1

[FIX] base_comment_template: Typo error

4bf4e51

base_comment_template 14.0.3.0.1

[MIG] base_comment_template: Migration to 15.0

36ae90b

[MIG] base_comment_template: Migration to 15.0

dd17489

TT35696

[UPD] Update base_comment_template.pot

668b7d3

[UPD] README.rst

3bbeec1

[MIG] base_comment_template : Migration to 16.0

87f62e2

AMhadhbi changed the title ~~[16.0] [MIG] base_comment-template~~ [16.0] [MIG] base_comment_template Oct 18, 2022

AMhadhbi mentioned this pull request Oct 19, 2022

[16.0] [MIG] account_comment_template OCA/account-invoice-reporting#242

Closed

OCA-git-bot added this to the 16.0 milestone Oct 19, 2022

OCA-git-bot mentioned this pull request Oct 19, 2022

Migration to version 16.0 #653

Open

15 tasks

marylla approved these changes Oct 24, 2022

View reviewed changes

chandni299 approved these changes Oct 25, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 25, 2022

OCA-git-bot added the bot is merging ⏳ label Oct 25, 2022

OCA-git-bot merged commit 267fdbf into OCA:16.0 Oct 25, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[16.0] [MIG] base_comment_template #664

[16.0] [MIG] base_comment_template #664

Uh oh!

AMhadhbi commented Oct 18, 2022

Uh oh!

AMhadhbi commented Oct 19, 2022

Uh oh!

OCA-git-bot commented Oct 19, 2022

Uh oh!

pedrobaeza commented Oct 19, 2022

Uh oh!

marylla left a comment

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

marylla commented Oct 25, 2022

Uh oh!

pedrobaeza commented Oct 25, 2022

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

[16.0] [MIG] base_comment_template #664

[16.0] [MIG] base_comment_template #664

Uh oh!

Conversation

AMhadhbi commented Oct 18, 2022

Uh oh!

AMhadhbi commented Oct 19, 2022

Uh oh!

OCA-git-bot commented Oct 19, 2022

Uh oh!

pedrobaeza commented Oct 19, 2022

Uh oh!

marylla left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

marylla commented Oct 25, 2022

Uh oh!

pedrobaeza commented Oct 25, 2022

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

OCA-git-bot commented Oct 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants