[MIG] Migration of 'report_xls' Module #118
Conversation
Zhouhao12345
changed the title
Zhouhao12345
changed the title
elicoidal
left a comment
elicoidal
left a comment
There was a problem hiding this comment.
Small details. Nevertheless you need to change the README file as well.
report_xls/__openerp__.py
Outdated
| { | ||
| 'name': 'Excel report engine', | ||
| 'version': '8.0.0.6.1', | ||
| 'version': '9.0.0.0.6', |
| @@ -1,4 +1,4 @@ | |||
| # -*- encoding: utf-8 -*- | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
@Zhouhao12345 Thanks for your contribution to the OCA.
Let me introduce to you some basic information about contribution in OCA and I will review other points in more comments inside the code..
In general, please follow the principles:
- Contribution guidelines: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md
- Please follow the OCA README template:
https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst - We recommend to include a screenshot as well to help new comers (nice to have)
- Please use simple headers in all py files following OCA templates
https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L3
|
This was discussed in a PR that ended closed, maybe is related, please have a look: #95 |
|
@lreficent I see that. |
|
We will use the report_xlsx in our side. |
|
@elicoidal Yes, maybe we can use this PR to remove it definitely. |
|
@dreispt @pedrobaeza would you agree with the idea? |
3 participants
This modification was going to update the report_xls module, and port it to version.9 of odoo, which was based on the responsity '[email protected]:ju-san/report_xls.git' @elicoidal @xuan139