Skip to content

Conversation

@alan196
Copy link

@alan196 alan196 commented Sep 30, 2021

Proposed changes

Migration PR for module project_task_report.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

LoisRForgeFlow and others added 23 commits September 29, 2021 19:03
Currently translated at 100.0% (12 of 12 strings)

Translation: project-reporting-11.0/project-reporting-11.0-project_task_report
Translate-URL: https://translation.odoo-community.org/projects/project-reporting-11-0/project-reporting-11-0-project_task_report/sl/
Currently translated at 91.7% (11 of 12 strings)

Translation: project-reporting-12.0/project-reporting-12.0-project_task_report
Translate-URL: https://translation.odoo-community.org/projects/project-reporting-12-0/project-reporting-12-0-project_task_report/hr/
Currently translated at 91.7% (11 of 12 strings)

Translation: project-reporting-12.0/project-reporting-12.0-project_task_report
Translate-URL: https://translation.odoo-community.org/projects/project-reporting-12-0/project-reporting-12-0-project_task_report/es/
Currently translated at 100.0% (12 of 12 strings)

Translation: project-reporting-12.0/project-reporting-12.0-project_task_report
Translate-URL: https://translation.odoo-community.org/projects/project-reporting-12-0/project-reporting-12-0-project_task_report/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-reporting-13.0/project-reporting-13.0-project_task_report
Translate-URL: https://translation.odoo-community.org/projects/project-reporting-13-0/project-reporting-13-0-project_task_report/
Copy link

@chusamo chusamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Functional Review

Copy link

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested 👍
Maybe task report & task chatter report inheritance could be improved in order to prevent code repeating, but it could be achieved in a later PR.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dalonsod
Copy link

dalonsod commented Jul 4, 2022

Hello @dreispt is this PR ready to be merged? Thanks!

@dreispt
Copy link
Member

dreispt commented Jul 5, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-44-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8c34da9 into OCA:14.0 Jul 5, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79ed4fb. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 14.0-mig-project_task_report branch July 7, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.